Yes, you’re right!

Should I update my fork and send an updated pull?

Thanks for a great utility!

Kind regards,
Mikael


--  
Mikael Bartlett
Technical Director @ NIXON NIXON
Direct: +46766366244
mikael@nixonnixon.se
http://www.nixonnixon.se



On Wednesday 19 March 2014 at 11:55, Gordon Fontenot wrote:

> In lib/liftoff/xcodeproj_helper.rb:
> > @@ -43,6 +43,15 @@ def add_todo_script_phase(enable_todos) > add_shell_script_build_phase(file_manager.template_contents('todo.sh (http://todo.sh)'), 'Warn for TODO and FIXME comments') > end > end > + > + def add_script_phases(scripts)  
> This is duplicating the essential functionality of add_todo_script_phase. Instead of adding this functionality separately, it would make more sense to move the TODO/FIXME script phase to be the default for this new feature.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/thoughtbot/liftoff/pull/120/files#r10744234).
>  
>  
>