Update rspec style

- Use allow instead of stub
- Unfortunately use double instead of stub_chain

Signed-off-by: caleb miles <cmiles@pivotallabs.com>
Vsphere client delete_path method should be idempotent

- Rescue file not found errors.
- Raise all other errors, including invalid path.

Signed-off-by: caleb miles <cmiles@pivotallabs.com>
Obtain ISO image location from cdrom configuration

Instead of assuming that ISO image is located on the same datastore where
VM virtual disks are located, use the cdrom device information to obtain ISO
location. DRS can move disks to different datastores leaving ISO images
in old datastore.

Signed-off-by: caleb miles <cmiles@pivotallabs.com>
Raise CloudError if env.json is not found

Signed-off-by: caleb miles <cmiles@pivotallabs.com>
Clean up old environment files when updating them

VM migration may leave env.json and env.iso in old datastore. These files
should be cleaned up on update. Otherwise they can be lost forever.

Signed-off-by: caleb miles <cmiles@pivotallabs.com>
Reconfigure cdrom when updating env files

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Only reconfigure cdrom once on vm creation

Previously, reconfigure was done manually inside create_vm, and then
again through agent_env.

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Add lifecycle test for vm migration

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Targetting -> Targeting

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>