If you have bandwidth then taking this would be awesome. I'm  a bit behind
on other comms work
On 24/02/2014 9:40 am, "James Kiesel" <notifications@github.com> wrote:

> In app/helpers/upload_helper.rb:
>
> > @@ -12,9 +12,9 @@ class S3Uploader
> >      def initialize(options)
> >        @options = options.reverse_merge(
> >          id: "fileupload",
> > -        aws_access_key_id: ENV['AWS_ACCESS_KEY_ID'],
> > -        aws_secret_access_key: ENV['AWS_SECRET_ACCESS_KEY'],
> > -        bucket: ENV['AWS_ATTACHMENTS_BUCKET'],
> > +        aws_access_key_id:     ENV.fetch('AWS_ACCESS_KEY_ID'),
> > +        aws_secret_access_key: ENV.fetch('AWS_SECRET_ACCESS_KEY'),
> > +        bucket:                ENV.fetch('AWS_ATTACHMENTS_BUCKET'),
>
> I have some bandwidth later in the day today; if it looks like it won't
> get done today, let me know?
> ... <#1446079eee5eab75_>
> On Mon, Feb 24, 2014 at 9:38 AM, Robert Guthrie <notifications@github.com>wrote:
> In app/helpers/upload_helper.rb: > @@ -12,9 +12,9 @@ class S3Uploader > def
> initialize(options) > @options <https://github.com/options> =
> options.reverse_merge( > id: "fileupload", > - aws_access_key_id:
> ENV['AWS_ACCESS_KEY_ID'], > - aws_secret_access_key:
> ENV['AWS_SECRET_ACCESS_KEY'], > - bucket: ENV['AWS_ATTACHMENTS_BUCKET'], >
> + aws_access_key_id: ENV.fetch('AWS_ACCESS_KEY_ID'), > +
> aws_secret_access_key: ENV.fetch('AWS_SECRET_ACCESS_KEY'), > + bucket:
> ENV.fetch('AWS_ATTACHMENTS_BUCKET'), Yep. So please add a check above it
> all that contains a single error message about setting up AWS ENV variables
> if any one var is missing. -- Reply to this email directly or view it on
> GitHub<https://github.com/loomio/loomio/pull/1270/files#r9977530> .
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/loomio/loomio/pull/1270/files#r9977538>
> .
>