all params works now