It can't be in SystemRewriteDriverFactory since ServerContext creation is
different between Apache and
nginx --- and Apache one needs server_rec



On Fri, Feb 7, 2014 at 4:33 PM, Jud Porter <notifications@github.com> wrote:

> In src/ngx_rewrite_driver_factory.cc:
>
> > @@ -177,6 +179,12 @@ NgxServerContext* NgxRewriteDriverFactory::MakeNgxServerContext(
> >    return server_context;
> >  }
> >
> > +ServerContext* NgxRewriteDriverFactory::NewDecodingServerContext() {
>
> See https://code.google.com/p/modpagespeed/source/detail?r=3764. It's an
> optimization to reduce memory utilization. It might be better though to
> pipe this through the SystemRewriteDriverFactory instead of having
> NgxRewriteDriverFactory and ApacheRewriteDriverFactory have separate
> implementations. Thoughts @morlovich <https://github.com/morlovich>?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pagespeed/ngx_pagespeed/pull/616/files#r9556021>
> .
>