Update to metasploit-credential to use gem.

MSP-10808
Use metasploit-credential with association search

MSP-10029
Fix typo and full path issue

Previously, the JtR library was prepending the path to data/john/ for
shipped bins; without it, modules weren't finding the executables.
Use All4 instead of LanMan

... Which was the original behavior. A full incremental LanMan can take
many hours instead of the few seconds this module was intended to run.
Fix running shipped bins by using a config file

This should get everything working again.

MSP-10817
Fix version restrictions on metasploit-credential

MSP-10029

The '<' version should have been '0.8' and not '0.7.10' because '0.8' is
the next incompatible version number.
Update metasploit_data_models and metasploit-credential for tag search

MSP-10029

Use metasploit_data_models that supports searching Mdm::Tag and a
compatible metasploit-credential.  Needed so
Metasploit::Credential::Core#tags can be searched in Pro.
Update spec to handle Mdm::Service#proto sequence

MSP-10029

Mdm::Service factories were changed in metasploit_data_models 0.19.0 to
use a sequence that cycles between 'tcp' and 'udp'.  To make the spec
clearer, just hard-code the protos under test instead of relying on
default behavior.
community string collection

add community string collection to handle snmp loginscanner
credentials
start refacotirng snmp_login
working snmp_login module
Merge branch 'feature/MSP-10029/core-search' into staging/electro-release

Support search
simple fix to mysql loginscanner

typo caused connection_timeout default to not get set
Merge branch 'staging/electro-release' of github.com:rapid7/metasploit-framework into staging/electro-release
Merge pull request #3559 from dmaloney-r7/feature/MSP-10230/snmp_login

MSP-10230 #land
Fix the case when john cracks only half of LM
Merge pull request #3555 from jlee-r7/bug/MSP-10817/jtr-typo

Now able to complete without error.

MSP-10817 #land
changing Credential == operator

it should no longer raise no method errors when comparing a credential to
an object that doesnt respond to public, private, or realm
Land #3566, ducktype better