[Master] Speed up TestRegionServerMetrics 10x

Author: adela

Summary: This test was very flaky because we start mini cluster and shut it down before and after every test case... fixing that

Test Plan: ran the test

Reviewers: daviddeng, liyintang, manukranthk, elliott

Reviewed By: elliott

CC: hbase-eng@, elliott

Differential Revision: https://phabricator.fb.com/D1291849

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1589815 13f79535-47bb-0310-9956-ffa450edef68
[HBASE-10986] Fix more hanging tests

Author: elliott

Summary:
New hanging tests from the last few test runs.
One was caused by an integer overflow.
I also made TestHRegionClose much faster by changing
to a BeforeClass setup.

Test Plan: ran each of the tests

Reviewers: liyintang, adela

Reviewed By: adela

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1292046

Task ID: 4142789

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1589816 13f79535-47bb-0310-9956-ffa450edef68
[master] Fail split task when split file cannot be closed

Author: fan

Summary: With some minor code cleanup

Test Plan: new unit test testUnableToCloseSplitFile

Reviewers: jiqingt, liyintang

Reviewed By: jiqingt

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1290752

Task ID: 4185227

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1589817 13f79535-47bb-0310-9956-ffa450edef68
[master] Removing the TestServerRPCAndThriftConcurrently test

Author: gauravm

Summary: We don't need to run this test, since we would not run RPC and Thrift concurrently

Test Plan: N/A

Reviewers: manukranthk, daviddeng, adela

Reviewed By: adela

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1292097

Task ID: 4183142

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1589818 13f79535-47bb-0310-9956-ffa450edef68
[HBASE-9930] Making callContext fully support profiling data in swift

Author: adela

Summary: we now support profiling time on the client and on the serverside. I also refactored a little bit the unit test for Header Protocol & profiling data

Test Plan:
extended TestHeaderSendReceive unit test, this is how it looks like
profiling data after first put: client_network_latency.ms:40, hlog_sync_time.ms:1, total_server_time.ms:5
profiling data after second put: client_network_latency.ms:3, hlog_sync_time.ms:1, total_server_time.ms:1
profiling data after get: client_network_latency.ms:3, total_server_time.ms:1
profiling data after get: client_network_latency.ms:4, total_server_time.ms:1

Reviewers: manukranthk, gauravm, fan

Reviewed By: manukranthk

CC: elliott, hbase-eng@

Differential Revision: https://phabricator.fb.com/D1290014

Task ID: 3573857

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1589819 13f79535-47bb-0310-9956-ffa450edef68
[HBASE-9704] Increasing the timeout on TestChangingEncoding#testCrazyRandomChanges

Author: manukranthk

Summary: Will increase the timeout here but keep the task open(mid-pri) for investigation later. This seemed like a better quick fix than muting.

Test Plan: Run the unit tests.

Reviewers: liyintang, adela, rshroff, gauravm, daviddeng

Reviewed By: daviddeng

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1292419

Task ID: 4191764

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1589820 13f79535-47bb-0310-9956-ffa450edef68
[HBASE-9704] Do not retry on Hadoop port on exceptions while creating a thrift client

Author: manukranthk

Summary: We added this functionality such that we will be able to connect to regionservers while in a rolling restart state. Since this assumption does not hold anymore. We should remove this retry and simply throw in case of a failure.

Test Plan: Not a major change. Removing a retry which doesn't work currently

Reviewers: aaiyer, gauravm, adela

Reviewed By: gauravm

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1290661

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1589821 13f79535-47bb-0310-9956-ffa450edef68
[master] Generate thrift files, some refactoring on thrift related things

Author: daviddeng

Summary:
`gen_thrift_from_swift.sh` is optimized, adding new classes, adding namespaces
`ArrayList` in endpoint service is replaced with `List`
Methods in parents of `ThriftHRegionInterface` are copied to `ThriftHRegionInterface` and annotated there because thrift doesn't support extending more than one parent.

Test Plan: `TestEndpoint`

Reviewers: manukranthk, adela, gauravm

Reviewed By: gauravm

CC: hbase-eng@, andrewcox

Differential Revision: https://phabricator.fb.com/D1287779

Task ID: 4147004

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1589822 13f79535-47bb-0310-9956-ffa450edef68
[master] Fix a small problem of not closing the scanner

Author: daviddeng

Summary:
If the user stops the scanning by calling `HTableClientScanner.close()` during scanning, it is possible the `Fetcher.callable` is not closed. A checking is added at the end of scanning to close the scanner if `callable` is not null.
Refactoring: not calling `Fetcher`'s private variable from outside.

Test Plan: `TestHTableClientScanner`

Reviewers: manukranthk, liyintang

Reviewed By: manukranthk

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1288020

Task ID: 3546998

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1589823 13f79535-47bb-0310-9956-ffa450edef68