fixed ::up bugs