Rename --leak_detective to --leak-detective
Spell options names and keywords with '-', not '_'.
This used to be the case but many newer ones didn't follow the convention.

- added  new spelling but retained the old ones.
  (Did not add new spelling for options that are obsolete.)

- start a notional timer for the removal of the old spelling
  (two releases?)

- added code to log a warning when a pluto flag has an underscore.
  Not yet done for ipsec.conf.

- change documentation to only refer to the new spelling

- remove some uses of previously obsolete options from ipsec.conf(5)
  and ipsec_pluto(5).  More remains to be done.
Remove ifdef on obsoleted CONFIG_KLIPS_BIGGATE
testing: Remove testing/packaging

It consisted of obsoleted "make install" targets for various cases.
alg_info.c: removed debug line interfering with testing

also added two comments to note we have test cases for these functions
Makefile.inc: if GCC or MAKE is not set, set it to gcc/make
prng.c: userland was not allowed to use it, but testing uses it

Allow userland to use it if SWAN_TESTING is defined
testing: functions.sh fixups

- Seems the MAKE macro isn't working fully. For now just set it to "make"
- Add -DSWAN_TESTING for prng.c
- Restored functions do_unittest() and unittest()

Note using functions.sh in make check in lib/libswan gives a weird
conflict with a modules() macro/alias elsewhere. I had to get rid of
the rpm for "environment-modules". I could not find the modules()
function to rename though.
testing: set LIBRESWANSRCDIR consistently
testing: rewrote testing/lib/libswan/algparse.c

- This now tests many more esp= and ah= lines than before.
- Known good output updated and more readable
- Old good output kept for reference for now
- Seems a passert() hits when we hit an error. This seems a change in
  behaviour that needs to be investigated. It prevents the test from
  continuing when an string error is found, which should not be the case
  (this happened already before the rewrite, it must be due to actual
   code changes)

new output looks like:

[  3des-sha1;modp1024]    OK: alg=3DES(3)_000-SHA1(2)_000; pfsgroup=MODP1024(2)
[  3des-sha1;modp1536]    OK: alg=3DES(3)_000-SHA1(2)_000; pfsgroup=MODP1536(5)
[  3des-sha1;modp2048]    OK: alg=3DES(3)_000-SHA1(2)_000; pfsgroup=MODP2048(14)
[      3des-sha1;dh22]    OK: alg=3DES(3)_000-SHA1(2)_000; pfsgroup=DH22(22)
[      3des-sha1;dh23]    OK: alg=3DES(3)_000-SHA1(2)_000; pfsgroup=DH23(23)
[      3des-sha1;dh24]    OK: alg=3DES(3)_000-SHA1(2)_000; pfsgroup=DH24(24)
[           3des-sha1]    OK: alg=3DES(3)_000-SHA1(2)_000
[           null-sha1]    OK: alg=NULL(11)_000-SHA1(2)_000
[         aes256-sha1]    OK: alg=AES(12)_256-SHA1(2)_000
[         aes128-sha1]    OK: alg=AES(12)_128-SHA1(2)_000
[            aes-sha1]    OK: alg=AES(12)_000-SHA1(2)_000

etc etc. See testing/lib/libswan/OUTPUT.algparse.txt
testing: new version of testing/lib/libswan/OUTPUT.algparse.txt
keylife.xml: rename to salifetime.xml and officially obsolete old keywords
improve formatting
slight improvements to pfkey code
Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan
documentation: fix xml parse error in nat_traversal.xml
pluto: RSA key: cleanup the secrets code

Remove a layer of indirection now that there is only the NSS method.

Remove password support from ipsec.secrets, as we no longer should
load private keys from files encrypted with passwords (or PINs)

Cleanup secrets man pages.
tidy programs/pluto/virtual.c:
- improve diagnostics
- prevent string overflow in show_virtual_private
- slightly safer deallocation of private_net_ok and private_net_ko
- eliminate incomplete support for %dhcp and %ike
formatting: join most lines with just ");" with the line above
Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan