Fix hardcoded gateway in IPV6 subnet api tests

This patch removes the hardcoding and calculates the Gateway-ip
based on the tenant_network_v6_cidr value.

Change-Id: Iee4c450714caf49d6753d9455e6ab3698b64340d
Closes-Bug: #1318962
Make unable to ping log messages appropriate level

The ping from an ssh connection checks in _check_remote_connectivity()
aren't necessarily expected to pass on the first attempt. However,
every time the ping was unsuccessful the method would log an
exception which is too severe a log for an expected error. This
commit uses a more appropriate log level for this case.

Change-Id: I8068fa85472259676acebd99b9d191065661e101
Remove unnecessary log message

This commit removes a useless log message from call_until_true. The
debug log there provides no useful debug information, just printing
that the sleep loop iterated doesn't enable any extra debugging. In
the worst case it ends up polluting the logs with the same message
while the loop times out. So let's just remove it.

Closes-Bug: #1336591
Change-Id: Ia0cec5c699470554a25c077082878772158f4c5a
Running without keystone v3 doesn't require uri_v3

uri_v3 is not required if api_v3 is false.

Change-Id: I5d63ca38b9f07ea07383472fb7fa82b369c72216
Closes-bug: #1295132
Don't use swift roles when no swift

If openstack doesn't have Swift installation this role assign is
unnecessary and cause bugs and fails for other tests.

Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8
remove default=None for config options

In the cfg module default=None is set as the default value.

Change-Id: I235decf26827bcb8076867f63c005ce5a80554fa
Move baremetal API tests to an /admin subdir

To avoid confusion, move all baremetal API tests to api/baremetal/admin and
add a README.rst explaining that the API provided by Ironic is meant to be used
as an admin and service level API.

Change-Id: Ib49b6d5937da6eedc3028a1f831552cf02d9f69e
Update compute attach tests to use "volume_device_name"

Some attach tests in the compute suites are using hard-coded
values for the volume device name. These should be replaced
with the compute.volume_device_name in tempest.conf.

Change-Id: I2f5da22b5f1bbd3910e4226b96e73106aa75c65a
test_neutron_resources to read template's values

test_neutron_resources create resources based on defined template
but the expected values are hard coded in this tests those should be
read from template.

Change-Id: I5ecc8742bab4c5d940c134945816c47acfba2282
Add network tags to test_quotas_negative

Partially implements bp add-service-tags

Change-Id: I37af14a34fa968874b4887616eaf8540f20fe7c1
If no volume, don't delete volume in teardown

If exception is thrown in setupClass before volume is created,
tearDownClass needn't delete volume.

Change-Id: I91c7eff8ec147b0ce3a9ea3e6c8d906ba68412c2
Closes-Bug: 1350167
Add compute tags to tempest/api/database/flavors test

Partially implements bp add-service-tags

Change-Id: Idfe3f86cfdb529340e5e290dd5dc8e9b549f7f5b
Add min_client_version decorator for CLI tests

This adds the min_client_version decorator to be used in the CLI tests.
The decorator is used skip CLI tests where the command being tested
isn't available in the version of the client we're testing against.

The cmd method is pulled out of the ClientTestBase class so it can be
used by the decorator and is renamed so it does not conflict with the
cmd argument passed to it.

To start using the decorator and show how it works, two known CLI tests
are decorated for minimum version checks on their clients.

Part of blueprint minversion-check-for-cli-tests

Change-Id: I8a0ee390048870d450772fa064d0dc2daa2b7036
More comments to doc strings

This patch continues to change comments back to doc strings.

Co-Authored With: Jamie Lennox <jamielennox@redhat.com>

Change-Id: I1618344f49cf151cf30ed5470417b27962a70999
Add a new credential provider to use a list of creds

This commit adds a new credential provider to use credentials provided
from a list of available credentials.

Partially implements bp test-accounts
Change-Id: I69c3105f8b413102ea567ccb92965572ce03d679
Change 'ceilometer' tag to 'telemetry' and add tags to cli tests

Partially implements bp add-service-tags

Change-Id: I8deca221918d9819c7a9f0a621fd3a21c6f66024
Allow out of quota failure status code to be 413 or 403

The commit I2bb8a60ef254afbfed514cfeebe75355d0de4475 tries to change
error codes of quota-out to suitable ones (HTTPForbidden).
We need to allow both HTTP413 and HTTP403 because branchless Tempest
needs to support both master and icehouse/stable branches.

Change-Id: I4a867ba9ffa43801bb05ce1d33687cb5b9a3e0fb
Related-Bug: #1298131
Add image-list to glance cli help test

In the glance client, there is 'image-list' that is not deprecated.
So this should be added to wanted_commands.

Change-Id: Ic14a9aa1ac24a7756e390a4f6e26e3af2952a52d
Stop leaking identity resources in teardown_all()

teardown_all() tries to delete all resources. But if an exception
happens, the rest of resources are remained and it seems to happen
frequently.
This commit fixes it.

Partially Implements: blueprint stop-leaking
Change-Id: I671b2262ea5ed5bf7d78149cf88f2894b6bf6508
Avoid unneeded use of set, and use list instead

This doesn't change anything, except fixing an unneeded compatibility
issue with py2.6.

Change-Id: I4bb7f6bea9fd34fdec8af3eed702c5a8743d3178