docstring fix

The docstring of class Extended_availability_zone was totally same as
Extended_server_attributes. This patch improves this docstring.

Change-Id: Ifd59d8dd149975c7f2653a0e0effadfc88d119d4
Fix string formatting of exception.NoUniqueMatch message

There is no implicit logger string formatting happening, so
we need to do this on our own.

Change-Id: I13dfb804d55b5ede2987e355f8a932f237b56c56
Sync unhandled exception logging change from Oslo

Copying changes from 1 Oslo commit: Ibf00173a07510b2ec0c81a29624004f17810a4e4
This is related to the bug fix for adding error type to unhandled
exception log message.

Change-Id: Ie8af57a148753121f79136af928feb0edaea228b
Closes-Bug: #1265561
Move logging out of BDM attach method

We will want to call attach in code paths other than booting an instance
(attaching a volume to a running instance for example). This patch
moves the boot specific log message out of the attach method.

Change-Id: Id70d3cabdd118ee1879d7b593765a5034a7ec88e
Remove vi modelines

We don't need to have the vi modelines in each source file,
it can be set in a user's vimrc if required.

Also a check is added to hacking to detect if they are re-added.

Change-Id: I347307a5145b2760c69085b6ca850d6a9137ffc6
Closes-Bug: #1229324
Enforce FlavorExtraSpecs Key format.

When creating a key name with characters like '/' that are not
being encoded or cannot be handled as expected by routes when
matching the url, then it's not possible to remove them anymore.
The new format apply the restriction: "[\w\.\- :]+$"

This change will fix the bug without API change.

Change-Id: I64bc098c4bde33c40fa149191a751ea3eb19f932
Closes-Bug: #1256119
Set SCSI as the default cdrom bus for PowerKVM

Set the default cdrom bus to scsi when the guest architecture is
ppc64 and the hypervisor is kvm|qemu. Checks the arch from
image_meta. Fallback to host arch if arch is not present in the
metadata associated with the image.

KVM unit tests without image_meta unified in a loop.

Change-Id: I62d1490ee8c9ba45a087f934342f14386ddb7cb2
Merge "Sync unhandled exception logging change from Oslo"
Merge "Fix string formatting of exception.NoUniqueMatch message"
Merge "docstring fix"
Merge "Remove vi modelines"
Add ESX quality warning

In line with the other drivers we've been marking as untested,
this patch marks the ESX driver as "not tested" in the logs to
alert admins to the fact. The VCenter driver is being tested
with minesweeper, and thus does not emit a similar message on
startup.

Change-Id: I9217bab01761f68b716cdce3b21c2653abd9afa1
Update nova.conf.sample for python-keystoneclient 0.5.0

python-keystoneclient 0.5.0 added a new oslo.config option:

 enforce_token_bind=permissive

Change-Id: If719600866561e03b037b1eb1f58e14103a99385
Add instance_get_active_by_window_joined to InstanceList

This is needed to remove get_active_by_window from nova compute API and
allow us to make the simple_tenant_usage API use Flavor objects.

Related to blueprint compute-manager-objects

Change-Id: I93354db2775f08346f9b812f1f1e78a4050efd4a
Merge "Update nova.conf.sample for python-keystoneclient 0.5.0"
Use new images when spawning BM instances.

With nova-BM the TFTP files (kernel and ramdisk) are cached between
instances but disks never are (today). We were treating the disk image
the same way but this is incorrect because its filename is 'disk'
rather than '$uuid' and as such it has to be cleaned out whenever a
deploy request is being processed.

Change-Id: I15c8fc25a4c064341b9f1ed51e6df8d1494fbdff
Co-Authored-By: Robert Collins <rbtcollins@hp.com>
Merge "Enforce FlavorExtraSpecs Key format."
Rename API schema modules with removing "_schema"

The paths of API schema modules include "/schemas" and they show
API schema clearly. It is not necessary to include "_schema" in
module names. This patch renames the modules with removing "_schema"
from module names.

@validaiton.schema() takes 1 parameter, so calling it by name
is excessive. Then, this patch removes the specified argument.

By applying these changes, we can specify API schema module in one
line with @validation.schema().

Partially implements blueprint nova-api-validation-fw

Change-Id: Ia646e1c2466fa0a1418f757a48d2e6b4f84f7c98
Avoid deadlock when stringifying NetworkInfo model

In the libvirt driver, we log information about the instance we're
about to generate XML for, which includes a NetworkInfo model. In
reality, this is a NetworkInfoAsyncWrapper which acquires a lock
on the model. Since we're in the middle of a log statement, we also
hold the logging lock. This happens right after we've fired off an
async request to update information about the instance, which first
acquired the network model lock and then acquired the logging lock
to make a seemingly innocuous log record.

The resulting deadlock is fixed by this patch by stringifying the
NetworkInfo object before making the log call in the libvirt
driver.

Change-Id: I81f35197ab7c74daa84fb51fbaa2df28c025da13
Closes-bug: 1276268
Merge "Rename API schema modules with removing "_schema""