(CPR-57) Style fixes

Now that the packaging repo has rubocop we need to have a baseline for
all future runs. This commit goes through and fixes all 316 detected
offenses.
Disagree; that's the same basic syntax in numerous languages (subtract from variable, set variable value to result). That's what I'd expect to see in bash.