u/fjammes/dm-1338

Reviewing DM-1338
I'm not sure qserv-configure.py currently performs all the controls, 
whereas it should do.
Nevertheless, if etc/sysconfig/qserv is edited by hand, these controls 
could be usefull?
Furthermore, having these controls is useful when developing on the 
configuration
procedure and more particularly on init.d scripts.

Is there a way to keep them without having something too complex? Or 
shall we remove them all?


On 10/30/2014 04:46 PM, Andy wrote:
>
> In admin/templates/configuration/etc/sysconfig/path.cfg.sh:
>
> > +# Handling paths, using eups or meta-config file
> > +# Author: Fabrice Jammes <fabrice.jammes@in2p3.fr> (09.17.2013)
> > +#-------------------------------------------------------------------------------
> > +
> > +# Set up a default search path.
> > +# Using value from QSERV_RUN_DIR/qserv-meta.conf
> > +
> > +check_dir_availability() {
> > +    # Test syntax.
> > +    if [ "$#" = 0 ] ; then
> > +	    echo $"Usage: check_dir_availability {varname1} ... {varnameN}"
> > +	    return 1
> > +    fi
> > +    for varname in "$@"
> > +    do
> > +        var=${!varname}
>
> I'm not at all sure that you need to check every variable. Don't you 
> trust the output of |qserv-configure|? Why does it have to be checked 
> in the scripts?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/LSST/qserv/pull/7/files#r19644385>.
>