REGRESSION (r173356): Downloading a disk image appends ".txt" to it
https://bugs.webkit.org/show_bug.cgi?id=137493
<rdar://problem/18321947>

Reviewed by Alexey Proskuryakov.

* Shared/Downloads/ios/DownloadIOS.mm:
(WebKit::Download::startWithHandle):
* Shared/Downloads/mac/DownloadMac.mm:
(WebKit::Download::startWithHandle):

    It appears that the synthesized NS/CFURLResponse fails to serialize the suggested filename correctly
    unless it has been accessed first.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Upgrade bugs.webkit.org to Bugzilla 4.2
<http://webkit.org/b/55882>

Upgrade to Bugzilla 4.2.1.

Conflicts:
    .htaccess
    Bugzilla.pm
    Bugzilla/Auth.pm
    Bugzilla/Auth/Login/CGI.pm
    Bugzilla/Auth/Persist/Cookie.pm
    Bugzilla/Bug.pm
    Bugzilla/BugMail.pm
    Bugzilla/CGI.pm
    Bugzilla/Config/Attachment.pm
    Bugzilla/Config/Common.pm
    Bugzilla/Config/General.pm
    Bugzilla/Constants.pm
    Bugzilla/DB/Mysql.pm
    Bugzilla/DB/Oracle.pm
    Bugzilla/DB/Schema.pm
    Bugzilla/DB/Schema/Oracle.pm
    Bugzilla/Error.pm
    Bugzilla/Flag.pm
    Bugzilla/FlagType.pm
    Bugzilla/Hook.pm
    Bugzilla/Install/DB.pm
    Bugzilla/Install/Filesystem.pm
    Bugzilla/Install/Localconfig.pm
    Bugzilla/Install/Requirements.pm
    Bugzilla/Install/Util.pm
    Bugzilla/Mailer.pm
    Bugzilla/Product.pm
    Bugzilla/Search.pm
    Bugzilla/Search/Quicksearch.pm
    Bugzilla/Search/Saved.pm
    Bugzilla/Series.pm
    Bugzilla/Template.pm
    Bugzilla/Template/Plugin/Hook.pm
    Bugzilla/Token.pm
    Bugzilla/User.pm
    Bugzilla/Util.pm
    Bugzilla/WebService.pm
    Bugzilla/WebService/Bug.pm
    Bugzilla/WebService/Bugzilla.pm
    Bugzilla/WebService/Constants.pm
    Bugzilla/WebService/Product.pm
    Bugzilla/WebService/User.pm
    attachment.cgi
    buglist.cgi
    checksetup.pl
    colchange.cgi
    collectstats.pl
    contrib/bugzilla_ldapsync.rb
    contrib/bzdbcopy.pl
    contrib/gnats2bz.pl
    contrib/recode.pl
    contrib/sendbugmail.pl
    contrib/yp_nomail.sh
    docs/en/xml/Bugzilla-Guide.xml
    docs/en/xml/about.xml
    docs/en/xml/installation.xml
    docs/en/xml/security.xml
    docs/en/xml/troubleshooting.xml
    editflagtypes.cgi
    editparams.cgi
    editproducts.cgi
    editvalues.cgi
    editwhines.cgi
    email_in.pl
    enter_bug.cgi
    extensions/BmpConvert/Config.pm
    extensions/OldBugMove/template/en/default/admin/params/oldbugmove.html.tmpl
    extensions/Voting/template/en/default/hook/bug/process/header-title.html.tmpl
    extensions/Voting/template/en/default/hook/search/search-report-select-rep_fields.html.tmpl
    extensions/example/code/webservice-error_codes.pl
    extensions/example/version.pl
    images/favicon.ico
    importxml.pl
    index.cgi
    install-module.pl
    js/field.js
    js/util.js
    long_list.cgi
    mod_perl.pl
    post_bug.cgi
    process_bug.cgi
    quips.cgi
    sanitycheck.cgi
    show_bug.cgi
    showattachment.cgi
    sidebar.cgi
    skins/contrib/Dusk/global.css
    skins/contrib/Dusk/index.css
    skins/standard/global.css
    skins/standard/show_bug.css
    t/008filter.t
    template/en/custom/attachment/review.html.tmpl
    template/en/default/account/prefs/saved-searches.html.tmpl
    template/en/default/admin/classifications/delete.html.tmpl
    template/en/default/admin/classifications/edit-common.html.tmpl
    template/en/default/admin/classifications/footer.html.tmpl
    template/en/default/admin/components/create.html.tmpl
    template/en/default/admin/components/edit.html.tmpl
    template/en/default/admin/params/attachment.html.tmpl
    template/en/default/admin/sanitycheck/messages.html.tmpl
    template/en/default/admin/users/confirm-delete.html.tmpl
    template/en/default/admin/workflow/edit.html.tmpl
    template/en/default/attachment/created.html.tmpl
    template/en/default/attachment/diff-header.html.tmpl
    template/en/default/attachment/edit.html.tmpl
    template/en/default/attachment/list.html.tmpl
    template/en/default/attachment/updated.html.tmpl
    template/en/default/bug/comments.html.tmpl
    template/en/default/bug/create/create-guided.html.tmpl
    template/en/default/bug/create/create.html.tmpl
    template/en/default/bug/create/created.html.tmpl
    template/en/default/bug/edit.html.tmpl
    template/en/default/bug/field.html.tmpl
    template/en/default/bug/process/header.html.tmpl
    template/en/default/bug/show.html.tmpl
    template/en/default/bug/show.xml.tmpl
    template/en/default/config.rdf.tmpl
    template/en/default/email/whine.txt.tmpl
    template/en/default/filterexceptions.pl
    template/en/default/flag/list.html.tmpl
    template/en/default/global/common-links.html.tmpl
    template/en/default/global/confirm-action.html.tmpl
    template/en/default/global/field-descs.none.tmpl
    template/en/default/global/footer.html.tmpl
    template/en/default/global/header.html.tmpl
    template/en/default/global/user-error.html.tmpl
    template/en/default/global/userselect.html.tmpl
    template/en/default/list/edit-multiple.html.tmpl
    template/en/default/list/list.html.tmpl
    template/en/default/pages/fields.html.tmpl
    template/en/default/pages/release-notes.html.tmpl
    template/en/default/search/boolean-charts.html.tmpl
    template/en/default/search/form.html.tmpl
    template/en/default/search/search-report-graph.html.tmpl
    template/en/default/search/search-report-table.html.tmpl
    template/en/default/setup/strings.txt.pl
    token.cgi
    userprefs.cgi
    xml.cgi
    xmlrpc.cgi

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Upgrade to Bugzilla 4.2.7.

Conflicts:
    buglist.cgi
    report.cgi

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
data/params: update after running checksetup.pl

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add .htaccess files created by checksetup.pl

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add back "WebKit Bugzilla" text in page header

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix review form after Bugzilla 4.2.5 update

* code-review.js:
(fetchHistory):
- Trim author since new format adds a space before the name.
- Update comment_marker to match the text now used by Bugzilla.

* template/en/custom/attachment/reviewform.html.tmpl:
- Add global/header.html.tmpl to make sure we get the standard
  HTML for including CSS, JavaScript, etc.
  - Remove redundant <link> tags.
  - Add CSS in local <style> to hide the header.
  - Change local <script> to be passed as an argument into
    global/header.html.tmpl when it is processed.
  - NOTE: local <style> tag should be passed as an argument into
    global/header.html.tmpl, but that breaks page layout, so it
    was skipped for now.
- Fix fallout form moving flag_types into the attachment object
  when processing flag/list.html.tmpl.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Move patch legalese into its own template file for reuse

* template/en/custom/attachment/create.html.tmpl:
* template/en/custom/attachment/patchlegalese.html.tmpl:
- Extract patch legalese into its own file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Get rid of large blank area when adding non-patch attachment

* js/attachment.js:
* template/en/custom/attachment/patchlegalese.html.tmpl:
- Use 'display: none;' and 'display: table-row;' instead of
  'visibility: collapse;' and 'visibility: visible;' to hide and
  show the text.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Display legal text when uploading a patch with a new bug

* js/attachment.js:
(setContentTypeDisabledState): Make this work on the Enter Bug
page so that the "Submit Bug" button changes to
"Agree and Submit Bug" when the "patch" checkbox is checked, and
it changes back to "Submit Bug" when unchecked.
* template/en/custom/attachment/createformcontents.html.tmpl:
Include the attachment/patchlegalese.html.tmpl template when
returning the page so that it will be shown when the "patch"
checkbox is checked.  Set the 'product' variable from the CGI
variable of the same name.
* template/en/custom/attachment/patchlegalese.html.tmpl: Add the
'expert_fields' class to the <tr> element so that it gets
shown/hidden when the Show/Hide Advanced Fields links are
clicked.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove references to Rietveld from bugs.webkit.org

Rietveld was an experiment that was added by Google.  It was
never enabled for everyone, so it's safe to remove the changes
that reference it.

* Bugzilla/Flag.pm: Remove code that prevented mail messages from
being sent for patches reviewed in Rietveld.
* attachment.cgi: Remove reference to the "rietveldreview"
template.
* template/en/custom/attachment/list.html.tmpl: Remove code
that handled the Rietveld review flag.
* template/en/custom/attachment/reviewform.html.tmpl: Remove code
that handled the "rietveldReview" CGI parameter.
* template/en/custom/attachment/rietveldreview.html.tmpl: Delete.
* template/en/custom/flag/list.html.tmpl: Delete.  After
removing the code to handle Rietveld reviews, there were no more
local WebKit changes to the custom template file, so it could be
removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix "View Diff" buttons on edit attachment page

* js/attachment.js:
(viewPrettyPatch): Change code syntax from Perl to JavaScript.
When I moved this method from
template/en/custom/attachment/edit.html.tmpl into
js/attachment.js during the Bugzilla 4.2.1 merge, I wrote some
of the code using Perl syntax.
* template/en/custom/attachment/edit.html.tmpl:
- Fix 120-column truncation of code.  (That's what you get for
  copying and pasting code from 'git diff' in a terminal
  window.)
- Pass attachment_id into the viewPrettyPatch() method since
  the method expects it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
migrate.pl: remove unnecessary change

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Re-fix Bug 26950: Make the summary and alias fields support click-to-edit <https://bugs.webkit.org/show_bug.cgi?id=26950>

* js/field.js: Port the changes from r45538 to Bugzilla 4.2.5.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Do not hide details on attachment edit page

* template/en/custom/attachment/edit.html.tmpl: Comment out the
call to toggle_attachment_details_visibility() that initially
hides the details.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Move template/en/custom files onto template/en/default

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Upgrade to Bugzilla 4.2.11.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove unneeded rule from .htaccess

* .htaccess: Remove an old rule that doesn't match any files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix maximum unshared memory size of Apache processes

* mod_perl.pl: Set the maximum unshared memory size of Apache
processes to 700 MB.  According to the manpage, this is the
correct way to do it in a mod_perl config file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update proxy URL parameter used by Bugzilla

* data/params: Update proxy URL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174782 268f45cc-cd09-0410-ab3c-d52691b4dbfc