if ((system_info_get_platform_bool(
> +      "tizen.org/feature/opengles.version.1_1",
> +      &b) == SYSTEM_INFO_ERROR_NONE)
> +      && b == true)
In this case the value is not directly returned....

string_full is fill with different option avaible in the target...


for "tizen.org/feature/fmradio"


  if (system_info_get_platform_bool("tizen.org/feature/fmradio",
      &b) == SYSTEM_INFO_ERROR_NONE)
    o["fmRadio"] = picojson::value(b);



Here fmRadio is not set in the case where there is an error, or if the
property is missing, it interpreted as if it is a false status....


Thanks for your comment







2014-02-07 15:54 GMT+01:00 Raphael Kubo da Costa <notifications@github.com>:

> In system_info/system_info_instance.cc:
>
> >      o["opengles"] = picojson::value(true);
> > -
> > -    if (strstr(s, "1.1"))
> > +    if ((system_info_get_platform_bool(
> > +      "tizen.org/feature/opengles.version.1_1",
> > +      &b) == SYSTEM_INFO_ERROR_NONE)
> > +      && b == true)
>
> Baptiste DURAND <notifications@github.com> writes:
> > o["opengles"] = picojson::value(true); > - > - if (strstr(s, "1.1")) > +
> if ((system_info_get_platform_bool( > + "
> tizen.org/feature/opengles.version.1_1", > + &b) ==
> SYSTEM_INFO_ERROR_NONE) > + && b == true) Sorry, You are wrong, Sure, we
> should test the value. Remember, there are 3 cases: the key "
> tizen.org/feature/opengles.version.1_1<
> http://tizen.org/feature/opengles.version.1_1>is not present in the
> platform file . => o["openglesVersion1_1"] = false ====> In the code that
> equals to catch the Error the key "tizen.org/feature/opengles.version.1_1<
> http://tizen.org/feature/opengles.version.1_1>is existein the platform
> file . and the value associated is true => o["openglesVersion1_1"] = true
> the key "tizen.org/feature/opengles.version.1_1<
> http://tizen.org/feature/opengles.version.1_1>is existein the platform
> file . and the value associated is false => o["openglesVersion1_1"] = false
> having keys with false value is allowed.
> Right, and does it also apply to other places where the second check is
> not being performed (like the "tizen.org/feature/fmradio" one)?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/242/files#r9540747>
> .
>



-- 
Baptiste DURAND