add test for query params