Sorry,  can you explain what is the current convention?
On Apr 11, 2014 2:18 PM, "Xavier Antoviaque" <notifications@github.com>
wrote:

> In mentoring/public/js/questionnaire.js:
>
> > +
> > +      // Set the width/height
> > +      var tip = $('.tip', popupDOM)[0];
> > +      var data = $(tip).data();
> > +      if (data && data.width) {
> > +        popupDOM.css('width', data.width)
> > +      } else {
> > +        popupDOM.css('width', '')
> > +      }
> > +
> > +      if (data && data.height) {
> > +        popupDOM.css('height', data.height);
> > +      } else {
> > +        popupDOM.css('height', '')
> > +      }
> > +
>
> I'd rather keep the current convention -- if we update this everywhere,
> that's going to make any change we merge from the Harvard version of the
> XBlock conflict with the current codebase.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/edx-solutions/xblock-mentoring/pull/21/files#r11544951>
> .
>