Yup


On Fri, May 16, 2014 at 7:03 AM, Pierre Dulac <notifications@github.com>wrote:

> In app/models/notifier.rb:
>
> > -
> > -      Rails.logger.info "slack: #{filtered_message}"
> > -
> > -      slack_account.ping "",
> > -        :channel     => "##{chat_room}",
> > -        :username    => "Shipping #{repo_name}",
> > -        :icon_url    => "https://octodex.github.com/images/labtocat.png",
> > -        :attachments => [{
> > -          :text    => filtered_message,
> > -          :color   => green? ? "good" : "danger",
> > -          :pretext => pending? ? output_message : " "
> > -        }]
> > +module Notifier
> > +  def self.for(payload)
> > +    if slack?
> > +      Notifier::Slack.new(payload)
> >      elsif hipchat_token
>
> shouldn't is be if hipchat? instead ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/atmos/heaven-notifier/pull/16/files#r12739457>
> .
>