[TASK] SqlParser: Unify internal usage of tableType/engine

For create-table "tableType" was still used while an alter-table
used "engine".

Change-Id: Idee0e569e331ec66084484f1e8d55d9cab03ff9f
Resolves: #61129
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32376
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] Add missing check in PreparedStatement->execute()

When using prepared statements for inserts and updates, the
execute method currently fails due to a missing check on the
return value from $this->statement->result_metadata();

Resolves: #61229
Releases: 6.3, 6.2
Change-Id: Ida17f617915c36a0c2e91663eee64b4c358090e2
Reviewed-on: http://review.typo3.org/32457
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] Let Web-View respect TCEMAIN.previewDomain

Added previewDomain in order to have Web-View functioning in the
same way like Page-Preview does.

Change-Id: I7193cd93a2b9b2d175e162d3fab0b837aefd2487
Fixes: #61226
Related: #30889
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32512
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] getAvailableWorkspaces called statically

Use same call to getAvailableWorkspaces as in
checkAccess.

Resolves: #51420
Releases: 6.3, 6.2
Change-Id: Icbea4611d7bd498e25bf658d7f3fa5a74539f479
Reviewed-on: http://review.typo3.org/32562
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[TASK] Cleanup error handling code and settings description

The error handling code for PHP errors needs some cleanup.
So does the description of the related settings in the Install Tool.

Resolves: #61235
Releases: 6.3, 6.2
Change-Id: Ibd95fcdaa6a50a870035037a2332b95d2c5e1266
Reviewed-on: http://review.typo3.org/32568
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
[BUGFIX] Allow integers to be converted to objects

In TYPO3 CMS the identity of objects/ records are
integers (uids). Because of that, the persistent object
type converter should be able to convert integers to
objects, not only strings.

Releases: 6.2, 6.3
Resolves: #61292
Change-Id: I0b69295ae7adfdbe49cf19056614b984f34290c6
Reviewed-on: http://review.typo3.org/32592
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] where statement in typoscript select with stdWrap

The 'where' part of the statement now takes stdWrap properties
into account.

Resolves: #61117
Releases: 6.3, 6.2
Change-Id: Id1b2fe88a1cc72ca12acdb6628ed4b713e121798
Reviewed-on: http://review.typo3.org/32593
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] Make TCA property "exclusiveKeys" work with single key

It is necessary that "exclusiveValues" is a string in the JavaScript
method FormEngine.setSelectOptionFromExternalSource() because
in JavaScript strings (but not numbers) have a method match() which
is used in FormEngine.setSelectOptionFromExternalSource().

"exclusiveValues" representing a single key (e.g. -1) are of type
"Number" - in this case an JavaScript error is thrown when the
script calls match() on it.

This commit ensures that "exclusiveValues" is always casted to
String.

Resolves: #61276
Releases: 6.3, 6.2
Change-Id: I049a5e6d11b3b27be901baa1e00429ab200b9a04
Reviewed-on: http://review.typo3.org/32600
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] indexed_search: in some cases indexing does not work

In some cases $pObj->register['SYS_LASTCHANGED'] is NULL and therefore
a MySQL error occurs during indexing a page. So, in these cases,
we need to set the 'mtime' value by getting it from the page and we
always want to prevent a NULL-value getting inserted into the DB.

Resolves: #61135
Releases: 6.1, 6.2, 6.3
Change-Id: Idb78af3aa23350db4bd43f58638541e6b3ad3ae3
Reviewed-on: http://review.typo3.org/32601
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] colPos_list sets access to edit areas

The property mod.SHARED.colPos_list used to determine which columns
were visible in the Page module. With backend layouts it will only
determine which edit areas in the backend layout are accessible for
editing.

Resolves: #39967
Releases: 6.3, 6.2
Change-Id: Iba65ce84adf025802d1b0ebda00dff4d6299a06a
Reviewed-on: http://review.typo3.org/32615
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
[BUGFIX] Fix loading of registry entries for namespace

When calling get(), all entries for the given namespace are loaded only
if no value for this namespace has been set() before in the same run.

This patch fix this by tracking the loading of namespaces and check the
state before set() or get() is processed. In case the namespace was not
loaded before, the loadEntriesByNamespace() is called to prevent
overwrite of values.

Resolves: #53182
Releases: 6.3, 6.2
Change-Id: Ib09e5892e35cef998413d2f0d8039ed49a7e7226
Reviewed-on: http://review.typo3.org/32619
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
[TASK] Use SpriteIcon for Add icon in Scheduler

Resolves: #61395
Releases: 6.2, 6.3
Change-Id: If77a7b9163ef23d291ca6106c453da059fe5ff21
Reviewed-on: http://review.typo3.org/32621
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
[TASK] Travis-ci: Disable apc in PHP 5.4

APC for travis-ci on cli was disabled for PHP 5.3 already because of
instability. This patch kicks out APC for PHP 5.4 as well after
recent failed travis runs in this area.

Releases: master, 6.2
Change-Id: I1182a0fcfc5f94f7f778c9f0fde5f5d8672b17ee
Reviewed-on: http://review.typo3.org/32624
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
[BUGFIX] Remove PHP warnings when no icon is found in FormEngine

If running in development mode and an icon
in FormEngine is not found, TYPO3 shows
the PHP E_WARNING of getimagesize() in a flash message.

The check should therefore be done in a cleaner way,
without the @ symbol.

Releases: 6.3, 6.2
Resolves: #61394
Change-Id: I546faee95bf304e135709c3e1c95292f48daf3d7
Reviewed-on: http://review.typo3.org/32625
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
[TASK] Add indexed search icon to plugin wizard

Adds a small icon to the plugin wizard to avoid the hacky 2 click access.
The icon is added to the tab "Plug-Ins".

Change-Id: Ib0b9705acaf69c0c49de660174c536caedda9292
Resolves: #34298
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/9221
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: http://review.typo3.org/32634
[BUGFIX] Fix clear_cache for XCache < 3.0

The XCache API changed with version 3.0. Ubuntu 12.04 uses XCache
version 1.3.2 so we need to support the old API.

Resolves: #61175
Releases: 6.3, 6.2
Change-Id: I76e975222747c965c5ef6e062231209d398a1c15
Reviewed-on: http://review.typo3.org/32636
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] Add file existence check before processing it

This patch adds a check if a file exists before processing it.
If the file does not exist, all file functions will generate a warning.

Resolves: #61300
Releases: 6.3, 6.2
Change-Id: Ie829ec0ade8357b16f8a550d5f137593900720b9
Reviewed-on: http://review.typo3.org/32637
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
[BUGFIX] Overriding TCA results in Exception

This problem only occours when using "tree" as
display mode for TCA-type "select".
FlexForm-API brings a special configuration to add,
edit and remove items from a selectbox, but in
case of a select-tree it does not make sense. A
completely different API was called to render this tree.
This patch prevents modifying the select-tree.

Releases: 6.3, 6.2
Resolves: #54490
Change-Id: I3ad3c5c608d7968ba90117aa048014b00cfd44af
Reviewed-on: http://review.typo3.org/32643
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] Line breaks in string in compile* methods of the SqlParser

There are lines-breaks inside the string which produces
'SELECT * \n\t\t\t\tFROM table_name\n\t\t\t\tWHERE'
queries while compile the sql query back from the array.

This breaks the test for EXT:dbal because debugAndCompare()
function will die.

Releases: 6.3, 6.2
Resolves: #55648
Change-Id: Iab6ad451d30bb94494ebbd3cb3b69e661ee55c00
Reviewed-on: http://review.typo3.org/32648
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[TASK] Improve deprecation message in show_rechis.php

Use a more detailed message how to link to this script.

Resolves: #61458
Releases: 6.3, 6.2
Change-Id: Ifabac9033b72bea288b13a11d1e649f28b99f950
Reviewed-on: http://review.typo3.org/32661
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>