do I need to commit