Add support for equality constraints on associated types
Mostly non-behaviour-changing changes (style, etc.)
Reviewer comments
auto merge of #19391 : nick29581/rust/assoc-eq, r=nikomatsakis

r? @nikomatsakis 

cc @aturon (I think you were interested in this for some library stuff)

closes #18432