Remove alwaysUseBaselineOfPrimaryFont setting
https://bugs.webkit.org/show_bug.cgi?id=139770

Reviewed by Anders Carlsson.

Source/WebCore:

"FIXME: This is unneeded and should be removed."

This iOS-only setting has no clients anymore.

* page/Settings.in:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
(-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _preferencesChanged:]):

Source/WebKit2:

* Shared/WebPreferencesDefinitions.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@177498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[iOS] Log why cached resources are being revalidated using FeatureCounter API
https://bugs.webkit.org/show_bug.cgi?id=139759
<rdar://problem/19288177>

Reviewed by Antti Koivisto.

Log why cached resources are being revalidated using FeatureCounter API.
Also log if revalidation is successful or not.

No new tests, no behavior change.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::mustRevalidateDueToCacheHeaders):
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::failBeforeStarting):
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::loader):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
* platform/FeatureCounterKeys.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@177499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Internals methods return 0 instead of false when they fail
https://bugs.webkit.org/show_bug.cgi?id=139766

Reviewed by Darin Adler.

Some Internals method explicitly return 0 although
they expect boolean value.

No new tests, no behavior change.

* testing/Internals.cpp:
(WebCore::Internals::hasSpellingMarker):
(WebCore::Internals::hasAutocorrectedMarker):
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore::Internals::hasGrammarMarker):
Return false instead of 0.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@177500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove timeout from shouldBecome* functions in js-test.js
https://bugs.webkit.org/show_bug.cgi?id=139767

Reviewed by Darin Adler.

r156678 has removed this timeout from shouldBecome* in js-test-pre.js.
Get rid of it from js-test.js as well to make shouldBecome* functions sync
between js-test.js and js-test-pre.js

Additionally, sync minor coding style changes between them.

* resources/js-test.js:
(_waitForCondition):
(.condition):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
(shouldBecomeDifferent):
(._condition): Deleted.
(._failureHandler): Deleted.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@177501 268f45cc-cd09-0410-ab3c-d52691b4dbfc