working on product controller