agent: Fix leak in CockpitFakeManager when cancelled

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
agent: Fix leak in CockpitRestJson one per watch

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
daemon: Fix several leaks in machines code

Change to a better array for pointers and actually free the
array among other things.

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
websocket: Fix a couple leaks in WebSocket code

Were leaking all headers for each initial socket request

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
ws: Fix leak of login password bytes

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
ws: Fix a couple leaks in CockpitHandlers code

Were leaking hostname and a struct for each login request

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
ws: Fix leak of per HTTP request structure

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
ws: Fix a couple of leaks in CockpitWebService code

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
Fix leaks in various unit tests

These let us get a clean bill of health on definite leaks

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
Add leak checking for definite leaks to 'make check-memory'

Closes #960

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
test: Use RPM name cockpit-selinux-policy to be clearer

Since we'll start distributing the selinux policy, we want to
give it a good name. cockpit-selinux might be used for selinux
functionality, so use cockpit-selinux-policy.

Also mark our policy RPM as noarch

Closes #963
Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
agent: Fix sporadic crash when test-dbusjson finishes

Allow the DBus worker thread to properly cleanup all of its
own nastiness in the mainloop before bringing down the GTestDBus
bus.

GDBus is a can of worms with regard to cleanup. This is another
workaround.

Closes #968
Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
test: Filter out obnoxious Warnings about ssh host keys

The only reason we're using ssh in the first place is because there's
no good way to run commands remotely in a VM.

Closes #969
Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
test: Make creating of qemu-img disks be quiet

Closes #970
Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
shell: Add input space validation when adding a server

Add input validation and visual style when error occurs.
Avoid resizing the dialog when error messages show up.
Remove get_focus and lose_focus functions.
Add some restrictions for empty host name in case "Next" button is enabled accidentally.

Fixes #943
Closes #957
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: Remove extra spaces in cockpit-setup.js

Reviewed-by: Stef Walter <stefw@redhat.com>
shell: Moves realm leave error message and changes its color

Moves error message below the leave button and changes text color to red

Fixes: #934
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: Creates hover effect for server avatar

Fixes: #868
Closes: #972
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: Hide link local IPv6 addresses on the network overview page

Fixes #800
Closes #975
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: Put network interface name in a more prominent place

Fixes #799
Closes #976
Reviewed-by: Stef Walter <stefw@redhat.com>