net: fix confusing typo in comment

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/93750043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
net/http, strings, bytes: fix http race, revert part of Reader behavior change

I fixed this data race regression in two ways: in net/http itself, and also
partially reverting the change from https://codereview.appspot.com/77580046 .
Previously a Read from a strings.Reader or bytes.Reader returning 0 bytes
would not be a memory write. After 77580046 it was. This reverts that back
in case others depended on that. Also adds tests.

Fixes Issue 7856

LGTM=ruiu, iant
R=iant, ruiu
CC=golang-codereviews, gri
https://codereview.appspot.com/94740044
bufio: make all read functions UnreadByte-friendly

Fixes issue 7844.

LGTM=crawshaw
R=golang-codereviews, crawshaw
CC=golang-codereviews
https://codereview.appspot.com/90620045
net: make WriteMsg{IP,UDP,Unix} return the correct number of bytes transferred

Fixes issue 7645

LGTM=iant, bradfitz
R=iant, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/90170046
net/http/httputil: don't leak goroutines in DumpRequestOut

Fixes Issue 7869

LGTM=dsymonds
R=golang-codereviews
CC=adg, dsymonds, golang-codereviews, rsc
https://codereview.appspot.com/91770048
doc/contribute.html: link to wiki for more code review information

(from the discussions on CL 89650044)

LGTM=minux.ma, iant
R=iant, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/97770043

Committer: Ian Lance Taylor <iant@golang.org>
doc/debugging_with_gdb.html: add introductory disclaimer
The instructions in this document are useful but not reliable.
Explain the situation up top.

Fixes issue 7471.

LGTM=josharian, iant
R=golang-codereviews, josharian, iant
CC=golang-codereviews
https://codereview.appspot.com/96830045
      encoding/gob: handle interface types in isZero() by returning true for nil interfaces.

Fixes issue 7741.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/96830044

Committer: Rob Pike <r@golang.org>
os: cap reads and writes to 2GB on Darwin and FreeBSD

Fixes Issue 7812

LGTM=josharian, iant
R=rsc, iant, adg, ruiu, minux.ma, josharian
CC=golang-codereviews
https://codereview.appspot.com/89900044
src: fix issues found by go vet std

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/96850043

Committer: Ian Lance Taylor <iant@golang.org>
encoding/ascii85: handle non-data bytes correctly

Previously Read wouldn't return once its internal input buffer
is filled with non-data bytes.
Fixes issue 7875.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/90820043

Committer: Ian Lance Taylor <iant@golang.org>
net: Remove an unmatched unlock of ForkLock

Remove an RUnlock of syscall.ForkLock with no matching RLock.
Holding ForkLock in netFD.dup is unnecessary: dupCloseOnExecOld
locks and unlocks the lock on its own and dupCloseOnExec doesn't
need the ForkLock to be held.

LGTM=iant
R=golang-codereviews, bradfitz, iant
CC=golang-codereviews
https://codereview.appspot.com/99800044

Committer: Ian Lance Taylor <iant@golang.org>
net/http/httputil: tell people not to use ClientConn and ServerConn

A very smart developer at Gophercon just asked me to help debug
a problem and I was horrified to learn that he was using httputil's
ClientConn. I forgot ClientConn and ServerConn were even included
in Go 1! They should've been deleted.

Scare people away from using them. The net/http package does
not use them and they're unused, unmaintained and untouched in
4+ years.

LGTM=r
R=r, adg
CC=golang-codereviews
https://codereview.appspot.com/92790043
cmd/cgo: fix C.CString for strings containing null terminators under gccgo

Previously we used strndup(3) to implement C.CString for gccgo. This
is wrong because strndup assumes the string to be null terminated,
and stops at the first null terminator. Instead, use malloc
and memmove to create a copy of the string, as we do in the
gc implementation.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/96790047

Committer: Ian Lance Taylor <iant@golang.org>
misc/cgo/test/backdoor: add gccgo version of backdoor function

For the gc compiler the Go function Issue7695 is defined in
runtime.c, but there is no way to do that for gccgo, because
there is no way to get the correct pkgpath.  The test is not
important for gccgo in any case.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/93870044
syscall: fix handling socket control messages on dragonfly

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/91860043
doc: fix an article

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/91770050
net/tcp: fix check for openbsd in test

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/98740045

Committer: Ian Lance Taylor <iant@golang.org>
syscall: add missing SendmsgN for NaCl

Update issue 7645

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/98790044
syscall: don't display syscall prototype lines on godoc

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/90810045