typechecker: split function bodies into named and unnamed

Summary: The naming pass is currently rather odious architecturally.
 While pulling out the set of declarations, we're also calculating
 terminality and identifying special functions. But we're not doing
 any local inference, so all of that effort is happening in the wrong
 place.

 The first step, in this diff, is to introduce an ast node for a
 function body that consist of either a named block (currently
 everything, eventually only lambdas), or an unnamed block (currently
 nothing, eventually everything but lambdas).

Reviewed By: @jwatzman

Differential Revision: D1660732

Signature: t1:1660732:1415214964:d7bdae0e42155a2153a6847b42fc4c5e0fce111d
Have rpoSortCfgWithIds compute RPO ids instead of PO ids.

Summary: I wanted to index into the RPO-sorted block vector using the ids but it
was needlessly verbose ("block[block.size() - poId - 1]"), and all of
our uses of PO ids boiled down to "id1 < id2", which easily translates
to "rpoId1 > rpoId2".

Turns out that the use of the ids in reflowTypes was wrong too, it was
using them to detect back-edges, but it assumed they were RPO ids.

Reviewed By: @swtaarrs

Differential Revision: D1672905

Signature: t1:1672905:1415730536:a98b2f5b8d64e9a1a3a046220f8f68807b0c02e0
Fix lchown when no user found

Summary: Also add appropriate warnings

Increases Symfony from 89.68 to 89.8
Closes https://github.com/facebook/hhvm/pull/4194

Reviewed By: @JoelMarcey

Differential Revision: D1669950

Signature: t1:1669950:1415808530:a050c547474714b230cccd9cfd3d638160743d0f
Try to catch more information about a problem

Summary: The bug isn't this code, but this is where it crashes.  Add an assert
and hopefully we'll get more info.

Reviewed By: @alexmalyshev

Differential Revision: D1674370
Preserve index of sockets passed into/out-of socket_select()

Summary: Active sockets should remain at the offset they were at
on the way into the function call.  HHVM is currently renumbering
them from zero.

Closes #2698

Reviewed By: @JoelMarcey

Differential Revision: D1673788

Signature: t1:1673788:1415741539:0f295abe094e63076726f4101d8c74647f17a38b
Remove trailing junk from IP addresses for sockets

Summary: If IP addresses contain an additional '/' (potentially followed by other
characters) they should all be ignored. For instance prot://1.2.3.4:567/foo
is a connection to 1.2.3.4 on port 567 over protocol prot where /foo is
simply ignored.

Fixes #3154

Reviewed By: @JoelMarcey

Differential Revision: D1671652

Signature: t1:1671652:1415769458:5fd487f565ec5f3c4a801270b9857f8174c89070
Add getTypeText to ReflectionParameter

Summary: It is there and working, but hh complains about it as it is not in the hhi.

Reviewed By: @elgenie

Differential Revision: D1674730
Change the Profiler constructor to not necessarily force CPU affinity.

Summary: CPU affinity is needed to get monotonic real time clock ticks from rdtsc,
but that effectively disables running multiple threads in server mode.

Some profilers may not need the rdtsc data.

All existing profilers in the code base preserve their previous semantics.
Closes https://github.com/facebook/hhvm/pull/4163

Reviewed By: @JoelMarcey

Differential Revision: D1666121

Signature: t1:1666121:1415832657:60deae3e777ee3bddebd0bf97b0c4bbb3b820486
qlzcompress is not available everywhere, and there's no support for it i...

Summary: ...n OSS
Closes https://github.com/facebook/hhvm/pull/4236

Reviewed By: @JoelMarcey

Differential Revision: D1677289

Signature: t1:1677289:1415838727:13f5c39992451100d1131869f931f6c1ccb2128b
Remove magic quotes

Summary: It has beeen removed since PHP5.4
Closes https://github.com/facebook/hhvm/pull/4203

Reviewed By: @JoelMarcey

Differential Revision: D1669988

Signature: t1:1669988:1415843237:56b2bb711980d9d2e356a5e2799be290f975a155
Break regions after FCall & friends when using LLVM

Summary: When using the LLVM backend, we're going to break regions after
bytecodes that use bindcall or something similar. This is intended to be
temporary and for reasons too lengthy to go into here. I also cleaned things up
a little so we actually obey the intent of the EvalJitLLVM runtime option: 1
means Optimize translations only, while >1 means all translations.

Reviewed By: @jasone

Differential Revision: D1671586

Signature: t1:1671586:1415671170:c540b409c2d27aff6d9f00723a3d0e17fceb9e6e
Go back to individual cache props for statics

Summary: This diff is a prereq for experimenting with using individual props for instance methods when there are <N of them. It accomplishes a few things:
- Centralize the prop creation logic to make that experiment easier
- Go back to individaul props for statics. Statics almost certainly didn't contribute to the memory regression, and there tend to be only a couple per class so the extra layer was probably a negative
- Eliminates a local when using shared props in favor of emitting the int directly which should make that scenario slightly more efficient.

Reviewed By: @jano

Differential Revision: D1659983

Signature: t1:1659983:1415835257:6e1f6b6230da8b9637049b0d50087ca321e1f428
add at() to MysqlRow in hhi file

Summary: as subject

Reviewed By: @​anca

Differential Revision: D1677983

Signature: t1:1677983:1415840723:029c1dd8214a62e05edbb579c5d648255c34e5e1
unparse constants defined using define

Summary: The hack parser parses usage of "define" as a function call unless it happens to be using a String. This
unparses those correctly

Reviewed By: @jwatzman

Differential Revision: D1676521

Signature: t1:1676521:1415838137:32805e7539a9564f6e02785e7748c35e1f78fa61
merge lvalue and lvalue_foreach

Summary: A previous diff introduced lvalue_foreach inside GetLocals. This merges lvalue_foreach and lvalue
to capture lvalues. Any invalid representations that are possible should ideally be weeded out during the parsing phase.

Reviewed By: @elgenie

Differential Revision: D1678282

Signature: t1:1678282:1415846509:41c9055a003d372b0892078127896043f0870400
Pass absolute path from TranslatePath to TranslatePathRelative

Summary: When SafeFileAccess is on trying to access relative paths would always fail.
Additionally paths which failed the security check were being translated to be
the cwd, which could itself be outside the allowed directories.

Fixes #2774

Reviewed By: @JoelMarcey

Differential Revision: D1677651

Signature: t1:1677651:1415837620:50d0b15b04da5641f2f7c82a173c791e8478029f
Wait for clean shutdown on SIGHUP

Summary: HHVM is supposed to do a clean shutdown when it receives SIGHUP -
which it does when using LibEventServer - but with ProxygenServer, it spins off
an additional thread to shutdown queues, leaving the original thread to
re-raise the signal before the queues drain.  Fix this by waiting for the
servers to stop.

Reviewed By: @markw65

Differential Revision: D1675300

Signature: t1:1675300:1415808825:f77150b8cb0ea85eaf90d58095be4baeaea2d317
Fix use-after-free in the access logs

Summary: If a request put an apc string into the ServerNote
array, and then outlived all its peers, and the string was
replaced during the request, then the string could be freed
by the treadmill at the end of the request. We used to free
up the treadmill items prior to writing the access logs,
which could then fail.

Reviewed By: @ottoni

Differential Revision: D1674896
Add per kind ArrayFunc counters for ArrayTracer

Summary: Adds an array of std::atomic<uint64_t> to keep count of ArrayFunc per ArrayKind

Reviewed By: @edwinsmith

Differential Revision: D1623929
Fix duplicate unbound name errors

Summary: When naming a hint, we'd call `Env.class_name` on it twice
here, causing it to get looked up and canonicalized more than once --
and thus insert an error more than once if it was wrong, such as the
case in the github issue linked below. This is hard to test for --
`hh_server --check` will unique-ify errors, and `hh_single` will only
take the first one. Fixing the latter is beyond what I want to deal with
right now, so this manually tested fix it is.

Fixes https://github.com/facebook/hhvm/issues/3294

Reviewed By: @int3, @elgenie

Differential Revision: D1677992

Signature: t1:1677992:1415857065:675182d27592e614b5ee8864648b3367a2ef01e3