Wait for Neutron L2 Agent on Compute Node

The L2 Agent sometimes does not register until later on in the
deployment for some reason. This is just a work-around until that bug
can be properly understood.

Change-Id: Idbbc977aa2e13f2026de05ae7e6571bc9dd0a498
Closes-Bug: #1260440
Fix wait for Neutron L2 Agent

A recent commit adds a wait for the Neutron L2 agent to be ready before
continuing with devtest. wait_for seem to have trouble with the way the
quotes are escaped. This commit changes them to wildcards instead.

The check was also waiting for the agent on the notcompute node,
according to the commit message the compute node was what was
intended(which makes more sense), this commit also changes the
check to wait for the agent on compute.

Change-Id: I231cde6263dd193767989f65b87162cf96a2803c
Fix check for overcloud compute hostname

The overcloud compute hostname is actually overcloud-novacompute0-xxxxx,
so the extra dash here was failing the check.  This should hopefully
resolve the latest CD cloud failure.

Change-Id: I6dace6a34b79170a88aa571141bb3cb52ba08027
Wait for nova-compute to claim to be up

Even with wait conditions, it is hard to judge from inside the
nova-compute host that nova-compute has decided it is "up".

We can poll nova service-list to know that for sure however.

Change-Id: Ibad0faa24e7d551ef5e78a2e9c1bb8f7d31fa9d1
Closes-Bug: #1260543
Merge "Wait for nova-compute to claim to be up"
Make refresh-env more resilient for users

If it isn't sourced perfectly it trashes $PATH among other things.

Change-Id: Ia606b68e5a95bd59ad0e2cf54e148d0bbbba9cbc
Add POWER_MANAGER support to devtest.

Adds an optional POWER_MANAGER option to devtest which can be
used to control the power manager used within the seed and undercloud
images. This can be useful when using the devtest scripts w/ real
hardware.

This support already exists in tripleo-ci and once included in the
devtest scripts will make switching to the devtest scripts in
tripleo-ci easier.

Change-Id: I976aa2f89e965dc9024e7967d7e593fb1f874000
Suppress the error message in cleanup-env

"default" pool may not exist before cleaning. Suppress the possible
error message:
error: failed to get pool 'default'
error: Storage pool not found: no storage pool with matching name 'default'

Change-Id: I80b4e3732888c7ebadd03b7792a83dd2a6c411d5
Close-Bug: #1261257
Set pipefail on all devtest scripts

We are missing failures of any commands which pipe their output to
another command. That is particularly troubling as, for instance, we
were recently missing the fact that the overcloud-control image was
failing to build.

Change-Id: Ied3e9a6821d6c19d7e9e82f90a461b62c7b14ddf
Merge "Make refresh-env more resilient for users"
Merge "Suppress the error message in cleanup-env"
Merge "Add POWER_MANAGER support to devtest."
Preserve the overcloud rather than deleting it.

Users can delete it if they want, but updating should be the default,
because who wants to throw away a cloud on every run!

Change-Id: I3486640fc29d12f5ffdb50d6873dcb8272376ef7
Permit setting the overcloud image update policy.

This is needed to preserve /mnt when rebuilding nodes. In principle we
can do stateful updates with rolling heat stack updates and live
migrations of tenants, cinder data and swift data - but that is a lot
of overhead to use every time - this is just much quicker and is the
path we have agreed on for getting out of the quagmire we're in where
no-one can use us for production image based updates.

Change-Id: I0efa8f52864f49ccdb885f6f655c732c951b3f7a
Don't do one-time setup when updating a cloud.

Change-Id: I3a470304b9d9529863b1bbfca2c84f83b6c94c9d
Revert "Work around neutron floatingip race condition"

This reverts commit 38ac22ce7c4ea4ee9a86e1b6f2c3e5e31c8ba652.

Neutron claim the symptoms are fixed but there may be more issues
under the hood - we should see if thats the case.

Change-Id: I7e4c9448d9fc8ae10522d33495e9f6d2de64c129
Replace references to Quantum with Neutron in docs

Change-Id: Ib6450a6e2d24d3d3581f13d62e31073378f4eeab
Heat patchset has hit trunk.

We no longer need a custom heat to get rebuild --replace-ephemeral
support.

Change-Id: I801bd1bfcf83967bb8d328f6e1432f76ff17da84
Use Image IDs to make image based updates work

Currently Heat won't know that the Image ID of the names have changed,
so we have to pass in new image ids to make sure the updates actually
deploy the new image.

We change load-image to just output the Image ID to make this task
simpler.

Change-Id: I13031356c09cdeb3a606fd42da91cb8febc9849d
Merge "Don't do one-time setup when updating a cloud."