Warmups, RPS and Connect 4

No arguing with this one. it was originally a lot more readable, and then
certain team members got very enamored of one-liners when we refactored.

On Tue, Sep 23, 2014 at 11:35 AM, Paul Hyman <notifications@github.com>
wrote:

> In connect_four/connect_four.rb:
>
> > +#go for it
> > +#connect four
> > +
> > +
> > +#a board seven wide and 6 high
> > +#each column is a stack that can only be pushed onto
> > +#rejects move if stack is already 6
> > +require './connect_four_player.rb'
> > +require './connect_four_ai.rb'
> > +
> > +
> > +class ConnectFour
> > +  def initialize(game_type)
> > +    @board = Board.new
> > +    @player1 = Player.new(@board, "\u{2686}")
> > +    game_type ==1 ? @player2 = ConnectFourAI.new(@board, "\u{2688}") : @player2 = Player.new(@board, "\u{2688}")
>
> There's too much going on here for one line. This should be broken out and
> expanded a bit for easier readability.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vikingeducation/game_center_project/pull/2/files#r17929217>
> .
>



-- 

*Michael Alexander*

(310) 429-8822

alexandermw@gmail.com