update on generic js