W-0 Fixed the asset version and location for stylesheets and javascript files

I don’t think we should fix this in the framework.

It's doing too specific stuff that's not relevant to the framework.

Isn't it possible to fix it another way, like by extending the class in our
app code?
On Dec 8, 2014 6:04 PM, "Jeroen" <notifications@github.com> wrote:

> In lib/helper/AssetHelper.php:
>
> > + *
> > + * @return string
> > + */
> > +function buildUri($source)
> > +{
> > +    $asset_version = sfConfig::get('app_deployment_version');
> > +
> > +    parse_str(parse_url($source, PHP_URL_QUERY), $urlComponents);
> > +
> > +    if (!empty($asset_version) && !array_key_exists('v', $urlComponents)) {
> > +        $queryStringDelimiter = stristr($source, '?') ? '&amp;' : '?';
> > +        $source .= $queryStringDelimiter . 'v=' . $asset_version;
> > +    }
> > +
> > +    $staticUri = sfConfig::get('app_static_uri');
> > +    if (!empty($staticUri) && stripos($source, '//') === false) {
>
> What should the // check prevent?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Werkspot/symfony1/pull/2/files#r21467277>.
>