(maint) Fix unit of profile output

The profile aggregation stated that the times were in milliseconds (ms),
but they are actually in seconds (s).
(PUP-3081) Indicate catalog benchmark is for application

The message "Finished catalog run in $x seconds" may mislead users into
believing that the operation being benchmarked includes both catalog
catalog compilation, downloading, and application. The actual operation
being timed is the catalog application. We should give more indication
of this when reporting the benchmarked time.
Merge pull request #3121 from adrienthebo/maint/master/catalog-application-benchmark-message

(PUP-3081) Indicate catalog benchmark is for application
(PUP-3081) Remove dependencies on specific notice

This family of tests was applying manifests and predicating success
on a specific notice. The wording of the notice was changed which
broke these tests. But this also exposed that testing for this message
wasn't needed anyway - there are other steps in these tests that
do a real check for success/failure.

While I was in there I added some blank lines between test steps,
so that it's not quite such a wall of text. It's a bit more readable
now (I hope).
(PUP-3229) Remove deprecate methods in BaseSetting class

In Puppet::Settings::BaseSetting, the following 4 methods were deprecated
long ago. This commit removes them:
call_on_define
call_on_define=
setbycli
setbycli=

This commit also makes a one-line change in call_hook= to remove an
unneeded conditional assignment (value can't have been assigned since
the value.nil? check two lines above).
(PUP-3081) Check for absence of warnings rather than specific notices

For this ticket we changed the Notice associated with catalog application.
This test had a very specific regex it tested against, but the real issue
it was testing for was the absence of warnings rather than precise fidelity
to a particular pair of notices.

So this commit updates the regex to just check for the absence of warnings.
Merge remote-tracking branch 'kylog/issue/base_setting_cleanup_deprecations'

* kylog/issue/base_setting_cleanup_deprecations:
  (PUP-3229) Remove deprecate methods in BaseSetting class
Merge pull request #3130 from kylog/issue/pup-3081/acceptance-fixup

Issue/pup 3081/acceptance fixup
(PUP-3338) Allow specs to pass on 1.8.7
Merge pull request #3108 from zaphod42/maint/master/incorrect-unit

(maint) Fix unit of profile output