added rubocop todo list to mask current fails

Change-Id: Ie20d01a724c25d62005cca52c491ac756ae849d1
example of using new chefspec coverage report

about: https://sethvargo.com/chef-recipe-code-coverage/
output: https://gist.github.com/paulczar/6f9c6ddad71ef4cd6394

Change-Id: I77c32f13c85d26516ded961063412682665de4cb
Make sure the linuxbridge agent can be restarted

Add notifier to restart linuxbridge-agent when linuxbridge plugin
configuration file is updated.

Closes-bug: #1254981

Change-Id: I67e071d35c77f6ec36c8f2fd2bea34616801a486
Merge "added rubocop todo list to mask current fails"
Restart openvswitch-switch after installation

This minor change restarts openvswitch-switch after installation
as the openvswitch kernel module may not be present when that service
gets installed/started.  In that situation, subsequent ovs-vsctl
commands will hang.

Change-Id: Idb1c2442e313707ced70f0792f6cc22c5fc7ef39
Closes-Bug: 1267528
Filling out initial rubocop support for metadata.rb and the Gemfile.

https://blueprints.launchpad.net/openstack-chef/+spec/lint-and-unit-testing-for-havana
Removing tailor, cleaning up metadata and Gemfile and adding TESTING.md. Will
remove the .rubocop-todo.yml once the rest of the Rubocop support is filled out

* updating chefspec to 3.1.4 (for chefspec coverage)

Addresses: blueprint rubocop-for-network
Change-Id: I9c9c5b48f3e1174b1e7ec7b5451a6ad9fd82b5e0
Delete the rootwrap.d filters

Delete the rootwrap.d filters templates and use the config provided by
openstack upstream packages.

Change-Id: Ia386d550e2dbd939038c913b2bd5c0dda1fc0a8c
Merge "Filling out initial rubocop support for metadata.rb and the Gemfile."
Merge "Delete the rootwrap.d filters"
rubocop compliance

all cops now pass except for the following
(which are silenced in .rubocop.yml )

* LineLength, MethodLength: not sure if we care about these
* WordArray: I prefer [] vs %w{} for readability.

Conflicts:
	metadata.rb
	recipes/common.rb
	recipes/openvswitch.rb
	spec/openvswitch_spec.rb

Change-Id: I92996b5db9f292e9ba93c7619ca727ffa92ddd71
Setting rubocop to run against the entire cookbook.

Addresses: blueprint rubocop-for-network
Change-Id: Ia401f8821691780924c6b2569557106d664f7829
Move to use "get_password" instead of "{user,service,db}_password"

The user_password, service_password and db_password functions are redundant
since they simply call "secret". Creates a get_password function that
will accept a "type" of db, service or user.

All instances of these calls have been changed to call get_password.

Change-Id: I480c654de44dc83e78f9ec4085f1b83edadd91d6
Partial-Bug: #1195915
Migrate network database

Migrate network database like other cookbooks do (openstack-identity,
openstack-nova,openstack-image etc.). The database migration will
make the OpenStack upgrade using the cookbooks easier.

The patch passes the template_file from common.rb to server.rb using
node['openstack']['network']['plugin_config_file'].

Change-Id: I5e4ded912eaa4087714f9cb68088caf29b90b9c4
Merge "Setting rubocop to run against the entire cookbook."
Remove Berksfile.lock from dev branches

blueprint remove-berksfile-lock-from-dev-branches

Change-Id: I5648bc0fb5824823283149dd47f1727cc6b75f19
Remove ambiguity in stubbed methods in spec_helper

- Adjust the stubs in spec/spec_helper.rb to specify the appropriate
  number of expected variables.
- Add parenthensis around return values

Partial-Bug: #1271535
Change-Id: I1aa473e406059fec66b0b2c9a307e8eeb41b0996
Clean up cookbook for bp/clean-up-attr-for-mq-and-db

This change removes the attributes we'll be moving to openstack-common
and changes reference of those attributes to reflect new (more
consistent) namespace. We also fix a test where node isn't being
converged after setting attributes and import chefspec/berksfile in
spec/spec_helper.rb so we can run rspec outside of strainer.

Change-Id: I7e27a60c4245de2e4d8033439a2429d89006a356
Implements: blueprint clean-up-attr-for-mq-and-db
Update attributes to be rubocop compliant

- Update .rubocop.yml file to correctly check attributes
- Update attributes/default.rb to be rubocop compliant

Addresses: blueprint rubocop-for-network
Change-Id: I04ff5003d0e916369d58b05d19a6f16252f3604b
Update spec files to be rubocop compliant

- Update .rubocop.yml to include spec/**
- Update spec files to be rubocop compliant
- Inlcude 'chefspec/berkshelf' in spec_helper.rb for ease of use

Change-Id: Ief01cc34cc4f9f04e6ba6437f67bfd347975c3a8
Addresses: blueprint rubocop-for-network
Merge "Update attributes to be rubocop compliant"