fix function signature