The DIV .subButtons

This began from frustrations while trying to theme a subreddit, it's a minor and simple change to make things easier for subreddit designers.

I wanted to adjust the spacing around the subscribe buttons but the inline CSS was making it difficult. The DIV .subButtons wraps around subreddits' subscribe button as well as the shortcut and dashboard buttons, it sits directly below the 'Use subreddit style' checkbox (which this commit doesn't touch). In the current developer build the DIV .subButtons has had RESUtils.baseStyleProtection slapped onto it, which is currently not doing anything useful because it doesn't actually protect the buttons inside the DIV.

My commit takes the inline CSS that has always been on .subButtons and moves it into a class declaration, so that it can be overridden with other CSS. Additionally I removed RESUtils.baseStyleProtection from the DIV .subButtons because it is ineffective and only gets in the way.
it's effective. PM me on reddit and i'll send you an example.


On Fri, Jun 6, 2014 at 12:56 AM, githue <notifications@github.com> wrote:

> In lib/modules/dashboard.js:
>
> > @@ -855,7 +855,6 @@ modules['dashboard'] = {
> >  			dashboardToggle.setAttribute('data-subreddit', thisSubredditFragment)
> >  			dashboardToggle.addEventListener('click', modules['dashboard'].toggleDashboard, false);
> >  			$('#subButtons-' + thisSubredditFragment).append(dashboardToggle);
> > -			$('#subButtons-' + thisSubredditFragment).attr('style', RESUtils.baseStyleProtection + '; z-index: 2147483646 !important;');
>
> I would like to see what they're doing with it, because I'm not sure that
> line will be very effective.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/1191/files#r13477428>
> .
>