Replace <locale>.numCores with <locale>.maxTaskPar where appropriate.
Remove an extraneous space character.
Update tests that reference numCores to reflect maxTaskPar change.

A number of tests refer to <locale>.numCores.  Many do so in order to
parameterize parallelism.  Others do so in order to print information
about the testing environment.  Adjust all these to parameterize or also
print using maxTaskPar.
Fix a mis-coding.

I added new output lines for maxTaskPar in these tests, to go with the
existing ones for numCores, but I didn't put them under control of the
if-stmt that prevents printing them unless desired.  As a result, the
tests didn't match their .good files any more.  Fix that.
Removing old Samples

The Samples/ directory used to not be tested and was designed for
illustrative purposes.  It feels very stale, though, and seems like
it could be used for tests that are run for illustrative purposes,
so let's reclaim it.  Removing old samples for now.
Adding a sample test file matching the one in bestPractices/TestSystem.txt
Updating Test System documentation

The main change here was to add information about creating performance
tests to bring the major steps and common features together into one
place.

While here, I took a general wordsmithing pass over the existing text
and added mention of .bad files to the section on futures.

Made the existing (trivial) correctness test point to test/Samples/Correctness
just for completeness, even though it's ridiculous.  Over time, I think we
should add additional tests showing off different test system futures here.
Adding new sample performance test to the Samples/ directory

Also added it to GRAPHFILES (even though it won't add any useful data)
after nobody objected on chat or chapel_perf.  If we don't like this
over time, we can reconsider, or move it into misc, or ...
Add a top-level README to the Samples/ directory
Stopped treating Samples/ as special in the test system

The Samples/ directory was, historically, meant to be a set of
illustrative tests that were not tested by default; however,
as a result of not being tested, they also became stale and
disused.  Here, I'm repurposing the Samples/ directory to be
tested to keep it live, so am not having start_test skip over
it by default as it used to.  Updated documentation to reflect
this.
Merge branch 'master' of https://github.com/chapel-lang/chapel into perfTestInstructions
Merge pull request #295 from bradcray/perfTestInstructions

Add best practices instructions for creating performance tests

The main goal here was to create a performance test by updating the
bestPractices/TestSystem.txt to go through the steps required to
create a minimal interesting performance test with graph.  While
editing that file, I also did some wordsmithing to the previous
version and added information about .bad files for .futures.

In documenting this, I ended up creating a performance test to make
sure I had everything right, and then realized that putting this into
the test/ system for other developers to see (rather than only having
it be in the .txt file) would be valuable, so I added
Samples/Performance/ as a place to capture it.  I created Chapel and C
versions since that is a common and interesting idiom and I made a
.graph file for them, even though they plot completely bogus (and
static data).  I added it to GRAPHFILES so that we could make sure it
didn't break over time after nobody objected on the perf mailing list
or Cray chatroom.

Sung pointed out that the Samples/ directory has traditionally been
treated specially in start_test (it skipped over it, unless you asked
it not to), and as a result, Samples/ was very stale and not helpful.
So I blew away the existing Samples/ directory, and added the
(trivial) correctness test sample that was in the TestSystem.txt file
in a Correctness/ subdirectory.  Over time, I think it would be great
to document other aspects of the test system in TestSystem.txt and
illustrate them in the Samples/ directory but didn't want to get
pulled into that today.

So then I stopped having start_test treat Samples/ directory and
updated README.dirs in test/ to reflect that it's not so special
anymore.
Updating README and testReleaseHelp to include 'rehash' for csh users

Sadly, csh users who set their environment first and build second (as
we now require in the quickstart world) need to do a rehash in order
to update their path to see 'chpl'.  Added a step for them in the README
and updated the testReleaseHelp script to do the same thing.
Merge pull request #300 from bradcray/fixCshQuickStartWithRehash

Updating README and testReleaseHelp to include 'rehash' for csh users

[not reviewed, though concept approved by hilde, tvandoren]

Sadly, csh users who set their environment first and build second (as
we now require in the quickstart world) need to do a rehash in order
to update their path to see 'chpl'.  Added a step for them in the README
and updated the testReleaseHelp script to do the same thing.
Merge pull request #299 from ronawho/qthreads-timeouts

disable qthreads internal spinlocks for pgi/PrgEnv-pgi

[reviewed by @gbtitus]

pgi doesn't support the proper atomic intrinsics that are required for
spinlocks to be fast, so disable them for pgi, and PrgEnv-pgi
Merge pull request #301 from ronawho/qthreads-timeouts

Fix callStackSize check for qthreads

[reviewed by @bradcray]

Previously callStackSize only checked for the qthreads environment variables
that control guard pages to determine the size of the call stacks. However, we
can now control them through the --no-stack-checks/--stack-checks options (and
other options that imply them.) It seems like a lot of work to check for the
different options and maintain precedence level and everything. Instead this
just sets QT_INFO=1. If guard pages are on the message "QTHREADS: Guard Pages
Enabled" will print. This handles all cases, including if qthreads was built
without guard pages. It hard codes the message qthreads prints, but this is no
more fragile than coding in the guard page size.
Split out the graphs for EP and FT that are most important to us (largest that run)
Significant refactoring (mostly expansion) of graphs in the perf tracking suite

I added a bunch of graphs to the perf tracking suite that I think we should be
paying attention to (and removed one):

* EP Stream -- I took the version that has --local and --no-local results
  though I think all our stream graphs should be condensed down to 1-4
  and don't understand the relationship between this graph and the release
  version (TODO)

* Removed Global stream w/ promotion -- because the global stream graph we
  use subsumes this info

* added HPCC RA and HPL : the first because it's important to us; the
  second because it's fairly stable and interesting; FFT could also have
  been added, but it seems less stable (and is arguably less "the way
  we'd like to do it"

* added thread-ring and pidigits -- the former is now less noisy with
  qthreads; the latter is now interesting with GMP on in the nightly
  testing

* added NAS EP B, FT A, and IS S -- all of these need more eyes on them
  to make sure they're as we like them; but in the meantime they're
  fairly noise-free

* added many array performance tests -- I looked for ones that looked
  fairly noise-free; I think that maintaining/improving performance for
  these is key, so thought they were worth a look

* dynamic iterator -- of the various advanced iters, I chose this one
  because it's the one we use most commonly and because it had some
  interesting changes lately.

* various scalar idiom C vs. Chapel comparisons -- again, these will
  be key to performance and they're fairly noise-free

* compilation time -- grabbed this just so we have some sense of
  overall compiler performance from week-to-week without bringing
  up Elliot's full suite -- this can serve as a canary to look there.

* memory leaks for examples -- this is something else I'd like to keep
  an eye on.  I could imagine taking one graph from this suite, but
  didn't put in the time to split the one I liked off (probably memory
  leaks for examples)

* jacobi AST/generated code size -- something else worth tracking

* no-op -- maybe not worth tracking, but I wanted to err on including
  it.
Cleaned up the parsing of intent_expr

There was a small bug in how intent_expr was parsed. While here I
cleaned up the rest of it based off some feedback from Brad.
Update one last test to the new task intent syntax