add map_location rotate functions, and tests
Merge branch 'add_map_location_rotate'
get_relative_dir may take a const & argument
fixup header to restore gcc builds
Always indicate that faction was chosen when placing player.

This fixes bug #21977.
Minor style improvements.