Fix allocating a feedback vector of the wrong size

Move the call to |CompilationInfo::PrepareForCompilation| out of
|Scope::Analyze| and adjust all callers. Our instrumentation may change
feedback slot count after |Scope::Analyze| is called.