[MIG] Migration of account_renumber to 8.0.

> : I was kinda sure there was a good reason for the observation. Maybe just a comment without a rejection would have had the same illustrative effect without a work load increase.

Did I reject your PR? I didn't approve it yet for one reason that I wrote in https://github.com/OCA/account-financial-tools/pull/66#issuecomment-64788142: your PR needs a rebase.
Travis is not green; we can't merge it (probably a conflict). I thought that as anyway you had to rebase your branch and probably resolve a conflict, it wouldn't take too much time to change that as well.

I'm used to propose improvements and tips even if they are small, because I like to spread and share knowledge. I won't (and wouldn't have) refuse your PR if you don't change that, but that won't prevent me to write down what you should have done.

On the change itself, @sbidoul explained the reason. Indeed the gain is negligible here, still a good habit to take. There is another reason, for instance if you use a log handler with a logging aggregation service (like sentry), this one will able to group them if the substitution is done by the logger.

My apologies if you felt it bad, I didn't meant to offend.


@pedrobaeza  The notion of wrong and correct is often moot when discussing programming. Some will say a program is correct as soon as it runs, regardless the way it has been written.
I consider it as a wrong usage of the logging module.