windows: Fix leak of event handle on open_device() failure

Create a new free_hid_device() function which takes care of all the
resources in hid_device which may need to be freed/released.

Reported-by: Johan Lindh <johan@linkdata.se>
libusb: Properly wait for transfer cancellation on read_thread() exit

While triaging libusb bugs, I took an indepth look at:
https://github.com/libusbx/libusbx/issues/25

This has lead me to the conclusion that there are 2 issues with hidapi's
libusb code wrt waiting for the transfer cancellation on read_thread()
exit:

1) There is a race where hid_close() can successfully cancel the transfer
after a read_callback() has submitted it but before read_thread() checks
shutdown_thread.  If this race is hit, then the libusb_cancel_transfer()
in read_thread() will fail, causing read_thread() to not call
libusb_handle_events() to complete the cancelled transfer.  hid_close()
will then free the transfer, and if later on libusb_handle_events() gets
called on the same context, it will try to complete the now freed
transfer.  This is what I believe leads to the segfault described in
https://github.com/libusbx/libusbx/issues/25

2) hidapi uses one read_thread() per hid_device, so if there are multiple
hid_devices then there are multiple threads calling
libusb_handle_events(), in this case there is no guarantee that a single
libusb_handle_events() call will successfully lead to the cancelled
transfer being completed.  If the transfer completion is already handled
by another read_thread() and there are no other events, then the
libusb_handle_events() call will hang, and thus the pthread_join() and
thus hidapi_close() will hang.

As number 2 is a generic problem found in more libusb apps, libusb has
gotten a new API called libusb_handle_events_completed(), which takes an
extra pointer to an int, whose contents must be set to nonzero on
completion by the callback, which allows waiting for the completion of a
specific transfer in a race-free manner.

This patch switches the waiting for the transfer's final completion to
using libusb_handle_events_completed(), thereby fixing both issues.  Note
the while is necessary since libusb_handle_events_completed(), like
libusb_handle_events(), will return as soon as it has handled *any* event.
The difference with libusb_handle_events_completed() is that once it has
all the necessary internal libusb locks, it checks the contents of the
completed parameter, and will bail if that has become nonzero without
waiting for further events.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
gitignore: add config.* to .gitignore

This makes HIDAPI less noisy when used a git submodule.

Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
README: Add build dependencies

Some build system dependencies were missing from the documentation.
mac: Fix incorrect device list after device removal

On Mac OS X 10.8.x (Mountain Lion), if a device is connected, opened, then
closed, then unplugged, subsequent calls to hid_enumerate() will still
list the device (even though it's been unplugged).  If the device is
plugged in again, a second instance will show up in the list and often it
will be impossible to open either.  Github user TamToucan figured out that
in hid_enumerate() if a call is made to IOHIDManagerSetDeviceMatching()
before the call to IOHIDManagerCopyDevices() that this will clear the
problem.

Thanks to TamToucan for figuring this out.
all: Fix license name

"GNU Public License" does not exist. It is called "GNU General Public
License", "GNU GPL" or simply "GPL".
libusb: Fix 'dev' memory leak on hid_init() failure.

Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
testgui: Remove pre-built testgui executable

Executables should have never been in the repo to begin with.
autotools: Add mac_support.h to Makefile.am

Not sure how this got missed.
HIDAPI 0.8.0-rc1
header: Clarify comment on hid_read() and hid_read_timeout()

Clarify that a return value of zero means no packet was available.
linux: Better kernel version detection

Refactor version detection into a function.
Handle versions of form X.Y.Z as well as X.Y.
Don't do workarounds for old kernels if version cannot be detected.
hidtest: Remove "All Rights Reserved" from hidtest.cpp

The language may be confusing for this file, since the hidtest.cpp file
may be used by anyone for any reason.
libusb: Add support for compiling on Debian/kFreeBSD
libusb: Include PTHREAD_CFLAGS when linking libhidapi-libusb

m4/ax_pthread.m4 says that PTHREAD_CFLAGS needs to be provided to the
linker line as well as the compile line.  This enables static library
builds of hidapi.
windows: Set the OS report buffer size to 64 reports

Resolves issues with dropped input reports when receiving a large amount
of data.
configure: Check for Fox 1.7 as well as Fox 1.6 for the testgui

The testgui will work with both, so check for them both at
configure time.

This came from Alex Barker <alex@1stleg.com> and was posted on github.
windows: Limit hid_read() return value to buffer length

hid_read() and hid_read_timeout() now return the number of bytes copied,
instead of the number of bytes returned by GetOverlappekdResult() (which is
the maximum report size for the device).  This limits the return value to
the requested length (buffer size), matching the behavior on other
platforms.
libusb: Fix null pointer dereference in hid_open()

Make sure hid_device_info.serial_number is not null before passing it to
wcscmp().

When libusb can't open a device for any reason (e.g. file system
permissions), hid_device_info.serial_number is NULL. Make sure
hid_device_info.serial_number is not null before passing it to wcscmp(3).

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
libusb: Add Android support

This code originally came from Pekka Nikander <pekka.nikander@senseg.com>