Merge pull request #43 from xavery/master

Proposed fix for JENKINS-21609
Merge pull request #44 from xavery/master

Supplemental fix for JENKINS-21609
[JENKINS-19649] fix issue where view mask and clean can get stuck in an enabled state
[FIXED JENKINS-19649] viewmask config fix

fixed condition for using the view mask for changelog
fixed issue where view mask for changelog option could be enabled when loading config
added test for optional configuration sections
typo fix
Merge pull request #48 from mlbright/master

typo fix
Fix for JENKINS-11600, email-ext now queries getTimestamp and getCommitId
swapping order of param substitution when getting effective client name so build parameters are properly evaluated
Added the jsr305 dependency

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Moved the variables substitution logic to MacroStringHelper

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Handle node environment variables in getDefaultSubstitutions(Node)

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Added Coverity folder to .gitignore

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Made MacroStringHelper as generic as possible.
I've also added substituteParameters(String, Node, AbstractProject, ...) to generalize non-build substitutions like checkouts.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Added PerforceSCM instance parameter to new MacroStringHelper methods

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Aggressive substitution error checks in PerforceSCM.
All methods have been migrated to the new MacroStringHelper API.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Added PerforceSCM retrieval method to PerforceTagAction

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Fix missing substitutions in PerforceSCM and PerforceTagNotifier.
All auxiliary methods in MacroStringHelper have been converted to private.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Refactoring of MacroStringHelper: annotations, proper variables substitution, etc

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Minor refactoring of PerforceSCM class

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Generalized the substitution of ${nodename}, ${hostname} and ${hash}

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>