started to add test cases