update with all function