VAAPI: Don't use swfilter for large surfaces - fallback to vaapi render

This stops using of sse copy routines for large surfaces. It introduces a fallback to the swrender - cause the statemachine wants a correctly setup m_pp after that method, if we don't care for this AddPicture will segfault.

Open for more input, e.g. better error handling.
In understand that well, but in case of this single method where absolutely
nothing happens, you could set the breakpoint with the caller as that will
be the point where you branch anyways.


2014-06-29 16:49 GMT+02:00 Rainer Hochecker <notifications@github.com>:

> In xbmc/cores/dvdplayer/DVDCodecs/Video/VAAPI.cpp:
>
> > @@ -2247,11 +2264,7 @@ void CSkipPostproc::Flush()
> >
> >  bool CSkipPostproc::Compatible(EINTERLACEMETHOD method)
> >  {
> > -  if (method == VS_INTERLACEMETHOD_NONE &&
> > -      CSettings::Get().GetBool("videoplayer.prefervaapirender"))
> > -    return true;
> > -
> > -  return false;
> > +  return (method == VS_INTERLACEMETHOD_NONE);
>
> cosinder the case that you want the debugger only break if method ==
> VS_INTERLACEMETHOD_NONE
>
> this is not bikeshedding. I often had to change XBMC code in order to able
> to debug properly.
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/FernetMenta/xbmc/pull/243/files#r14329687>.
>



-- 
                   Key-ID:     0x1A995A9B
                   keyserver: pgp.mit.edu
==============================================================
Fingerprint: 4606 DA19 EC2E 9A0B 0157  C81B DA07 CF63 1A99 5A9B