Merge branch 'master', remote-tracking branch 'upstream/master'
Merge remote-tracking branch 'upstream/master'
Fix #4119 - SMB lost search ID (sid) in find_first method

This will fix issue #4119. A bug in the find_first method in rex
SMB.

When the SMB client requests a TRANS2_FIND_FIRST2 for retriving
information about what items a directory has, the server returns
a response that contains an SID - a search identifier for the
transaction. If the SMB client wants more data, it must send a
TRANS2_FIND_NEXT2 request with the same SID. And then the server
will continue sending more until it runs out.

The root cause of this bug is that after the TRANS2_FIND_FIRST2
request is sent, our SMB's find_first method forgets the SID at
the end of the loop (out of scope).
Viproy VoIP Pen-Test Kit - Cisco CDP Testing Module
Viproy is removed from names
Author section is fixed
First round of basic Ruby style cleanup in cdp
Remove sniffing capabilities from cdp -- use wireshark/tcpdump instead
Use PacketFu::EthHeader.mac2str for MAC formatting
More CDP cleanup.  Loop, cleaner packet construction, style
Remove errant whitespace, unnecessary to_s
Remove report mixin which was not used
Remove unused options
Land #4061, @fozavci's CDP testing module
Add jduck as an author on samsung_knox_smdm_url
IN:SRV expansion for Fake DNS server
Author update for the fakedns module
FAKE and BYPASS actions are implemented for SRV queries
@jhart-r7 commits are accepted and conflicts fixed.
Don't artificially insert additional records when BYPASS
Add more consistent logging for fakedns types that support fake vs bypass