Not yet, sorry. Will finish tonight
On Apr 28, 2014 3:32 PM, "josenavas" <notifications@github.com> wrote:

> In biom/table.py:
>
> > @@ -1566,25 +1572,89 @@ def from_hdf5(cls, h5grp, order='observation'):
> >          if order not in ('observation', 'sample'):
> >              raise ValueError("Unknown order %s!" % order)
> >
> > -        shape = h5grp.attrs['shape']
> > +        # fetch the IDs
> > +        if observations is not None:
>
> Thanks @wasade <https://github.com/wasade>, completely missed this
> portion of duplicated code. I fixed it!
>
> I'm assuming that you're not done with the review right?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/biocore/biom-format/pull/315/files#r12063402>
> .
>