details: do not show MAC address if not set

Fixes this exception:
Traceback (most recent call last):
  File "virt-manager/virtManager/create.py", line 1780, in finish
    self.customize(guest)
  File "virt-manager/virtManager/create.py", line 1812, in customize
    self.config_window = vmmDetails(virtinst_guest, self.topwin)
  File "virt-manager/virtManager/details.py", line 560, in __init__
    self.populate_hw_list()
  File "virt-manager/virtManager/details.py", line 3165, in populate_hw_list
    self.repopulate_hw_list()
  File "virt-manager/virtManager/details.py", line 3220, in repopulate_hw_list
    update_hwlist(HW_LIST_TYPE_NIC, dev)
  File "virt-manager/virtManager/details.py", line 3195, in update_hwlist
    label = _label_for_device(dev)
  File "virt-manager/virtManager/details.py", line 188, in _label_for_device
    return "NIC %s" % dev.macaddr[-9:]
TypeError: 'NoneType' object has no attribute '__getitem__'

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1164123

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
tunnels: do not close unowned fd

The fd is handed to spice-gtk and gtk-vnc. They will close it when no
longer needed. Double closing leads to various race issues, since the
same fd may be opened for a different usage.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1081227
add gluster and sheepdog pool/volume to testdriver.xml
osdict: Add back compat 'virtio26' entry

We used to have that in the old osdict. Map it to fedora10 which gives
virtio net/block but nothing else, which matches the old behavior.
virt-manager: show the manager when using a wrong domain id

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1164691

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
HACKING: Make the test suite instructions the first listed bit
console: switch to CONSOLE_PAGE_UNAVAILABLE while waiting for login

It fixes a race condition if the ERROR_AUTH error if received while
still on the CONSOLE_PAGE_AUTHENTICATE and skipping the page_changed
event.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1165990

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
virtManager: show correctly IPv6 addresses

VirtualConnection.get_uri_host_port already splits this information
taking care of IPv6 addresses, do not split it again.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1094631

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
osdict: Remove unused diskbus field
guest: Use virtio-scsi for arm machvirt CDROM

Since it's the only option we have to actually use the CDROM
urlfetcher: Detect RHEL ARM distro from treeinfo
virt-install: Don't warn about missing console= for machvirt

Since latest kernels figure it out automatically
virt-install: Also don't show console= warning for machvirt + --location
tests: fix failures with libvirt upstream version

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
details: fix --show-domain-performance

the introspection page could be missing, in this case the tabs values
are shifted by one.  The new code looks for the correct row number
before selecting it.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1167600

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Merge branch 'master' of https://git.fedorahosted.org/git/virt-manager

Conflicts:
	tests/testdriver.xml