On 29/04/2014 17:06, Vincent Zurczak wrote:
>
> In 
> roboconf-agent/src/main/java/net/roboconf/agent/internal/AgentUtils.java:
>
> > @@ -183,6 +183,19 @@ public static AgentData findParametersInWsInfo( Logger logger ) {
> >  			ByteArrayOutputStream os = new ByteArrayOutputStream();
> >
> >  			Utils.copyStream( in, os );
> > +			String ip = os.toString( "UTF-8" );
> > +			if(! isValidIP(ip)) {
> > +				// Failed retrieving public IP: try private one instead
> > +				Utils.closeQuietly( in );
> > +				userDataUrl = new URL( "http://169.254.169.254/latest/meta-data/local-ipv4" );
> > +				in = userDataUrl.openStream();
>
> The input stream is not closed.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/roboconf/roboconf/pull/65/files#r12097780>.
>
In the "finally", it is.