updated but not working