Fixed Result type parameters in doc comment.
Removed unnecessary method in test
Parser: fix PatIdent span bug

Fix small bug introduced in e38cb972dcf: PatIdent span was incorrect
because self.last_span was being used before the ident token was
parsed.
vim: set Rust tab conventions
rustc: Reorder error and note message to reduce confusion.

Moved note after error to reduce confusion when the pair appears in the
middle of other errors. Closes #13279.
librustc: Make sure to run destructors in the right order when matching on moved value.
Refactored VecPerParamSpace to hide exposure of `Vec` representation.

This basically meant changing the interface so that no borrowed `&Vec`
is exposed, by hiding `fn get_vec` and `fn get_mut_vec` and revising
`fn all_vecs`.

Instead, clients should use one of the other methods; `get_slice`,
`pop`, `truncate`, `replace`, `push_all`, or `is_empty_in`, which
should work for any case currently used in rustc.
Revise `VecPerParamSpace` to use a one Vec rather than three.

In my informal measurements, this brings the peak memory usage when
building librustc from 1662M down to 1502M.  Since 1662 - 1502 = 160,
this may not recover the entirety of the observed memory regression
(250M) from PR #14604.  (However, according to my local measurements,
the regression when building librustc was more like 209M, so perhaps
this will still recover the lions share of the lost memory.)
auto merge of #15414 : zsiciarz/rust/patch-1, r=alexcrichton
auto merge of #15418 : pnkfelix/rust/fsk-revise-VecPerParamSpace, r=pcwalton

In my informal measurements, this brings the peak memory usage when
building librustc from 1662M down to 1502M.  Since 1662 - 1502 = 160,
this may not recover the entirety of the observed memory regression
(250M) from PR #14604.  (However, according to my local measurements,
the regression when building librustc was more like 209M, so perhaps
this will still recover the lions share of the lost memory.)
auto merge of #15442 : luqmana/rust/odp, r=pnkfelix

Inadvertently changed the order in which destructors ran in certain cases with #15076.

Fixes #15438.
auto merge of #15427 : aochagavia/rust/parse, r=pcwalton
auto merge of #15428 : phildawes/rust/master, r=huonw

Fix small bug introduced in e38cb972dcf: PatIdent span was incorrect
because self.last_span was being used before the ident token was
parsed.
auto merge of #15429 : kballard/rust/vim_tab_conventions, r=pcwalton
auto merge of #15431 : iliekturtles/rust/13279-error-msg-order, r=pcwalton

Moved note after error to reduce confusion when the pair appears in the
middle of other errors. Closes #13279.
syntax: doc comments all the things
token: replace ast::Ident with just Ident
testsuite: merge some lexer testcases

Now that the lexer is more robust, these tests don't need to be in separate
files. Yay!
str: use more helpful assertion failure messages
test: simplify numeric literal cfail tests