add test still need convert
finally passed