Yes for I might have exaggerated a bit... Fixing them right now...

There are also some parts with commented code snippets (/*...*/). Get rid
of them?


On Wed, Feb 19, 2014 at 3:09 PM, Martin Grigorov
<notifications@github.com>wrote:

> In
> bootstrap-samples/src/main/java/de/agilecoders/wicket/samples/components/basecss/ButtonGroups.java:
>
> > @@ -67,7 +67,7 @@ public ButtonGroups(final String markupId) {
> >       * @return The new button instance
> >       */
> >      private AbstractLink createIconButton(Icon icon) {
> > -        BootstrapBookmarkablePageLink button = new BootstrapBookmarkablePageLink(ButtonList.getButtonMarkupId(), ComponentsPage.class, Buttons.Type.Default);
> > +        BootstrapBookmarkablePageLink<ComponentsPage> button = new BootstrapBookmarkablePageLink<ComponentsPage>(ButtonList.getButtonMarkupId(), ComponentsPage.class, Buttons.Type.Default);
>
> For (Abstract)Link the generic is easy to understand.
> But for BookmarkablePageLink most of the time (99.99% ?!) there is no need
> of a model at all, so it is <Void>.
> I am not aware what 0.01% could be...
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/329/files#r9865403>
> .
>



-- 
Regards - Ernesto Reinaldo Barreiro