On Sun, Jun 01, 2014 at 12:28:19PM -0700, Hannu Valtonen wrote:
> > @@ -329,7 +329,7 @@ def pack_loose_objects(self):
> >          for sha in self._iter_loose_objects():
> >              objects.add((self._get_loose_object(sha), None))
> >          self.add_objects(list(objects))
> > -        for obj, path in objects:
> > +        for obj, path in objects: # pylint: disable=W0612
> 
> If we silence the pylint warnings that pointed them out we're just making finding new ones as they're introduced to the code impossible. Even now there are thousands of warnings it produces making the output pretty close to unreadable. If the warnings are not cleaned up it'll progressively get harder to use it. 
> 
> My basic stance on pylint warnings is more or less to equate them to C compiler warnings, fix them all and you may one day actually notice one that's useful. 
They're usually a different class of warnings though. C warnings are useful
because they can be an indication of lurking bugs. pylint warnings are
generally much more superficial, relating to formatting. I find pyflakes much
more useful in that regard.  

I have a similar low tolerance for a low signal-to-noise ratio warnings when it
comes to C compilers.

> Anyway, I don't feel like it's a good way to spend my time fixing line lengths to fit 80 characters which they've never done before or fixing indentation issues that are going to be ignored by the tool anyway in the future. 
> 
> I'll focus on getting the code to work on py3k instead. Thanks for the review effort though.
Fair enough. Sorry that this was a distraction; perhaps we should remove the
.pylintrc file as it isn't useful.

Cheers,

Jelmer