working on generator