fixed code comment
comment fix-sorry
Fix derive_module_ancestor_names

MSP-11130

Wrap :reference_name in an Array since :ancestor_reference_names is
expected to be an Array.
Fix Msf::PayloadGenerator spec constant leaks

MSP-11130

Remove the constant PAYLOAD_FRAMEWORK as it leads to a
Msf::Simple::Framework instance that is not cleaned up and loads modules
prior to the beginning of the suite run.
Fix constant leaks in Msf::Util::EXE spec

MSP-11130

Remove global $framework as it loads modules prior to suite run and they
are not cleaned up.
Remove Metasploit::Framework::Spec::Constants::Each.configured!

MSP-11130

No longer needed because all before suite leaks have been fixed.
Merge branch 'master' into feature/MSP-11130/metasploit-framework-spec-constants

MSP-11130

Conflicts:
	Rakefile
Add manual removal of `log/remove-cleaner` to Each removal

MSP-11130

When removing `Metasploit::Framework::Spec::Constants::Each.configure`
from spec/spec_helper.rb,
`Metasploit::Framework::Spec::Constants::Each.define_task` will see the
`log/remove-cleaner` from the last run unless it is manually removed.
Land #3516, @midnitesnake's snmp_enumusers fix for Solaris, OS X
Use `load_and_create_module` in modules_spec

MSP-11130

Reuse 'Msf::Simple::Framework#modules loading' context in 'all modules
with module type can be instantiated' instead of using the similar code.
Use 'Metasploit::Simple::Framework#modules loading' in 'payloads can be instantiated'

MSP-11130

Use `expect_to_load_module_ancestor` and `load_and_create_module` in
favor of the custom code in 'payloads can be instantiated'.
Add .log extension to metasploit/framework/spec/constants/suite log

MSP-11130
log/remove-cleaner -> log/metasploit/framework/spec/constants/each.log

MSP-11130

Rename log file to match naming scheme for
Metasploit::Framework::Spec::Constants::Suite.
Log Spec::Constants::Each error instead of flag.

MSP-11130

Instead of writing `1` to the file and then printing a verbose message
in the spec task action, log the verbose message and just print the log
in the spec task action, so other tools can just look at the log when
not using `rake spec`.

NOTE: Failing specs due to unnecessary
`Metasploit::Framework::Spec::Constants::Each.configure!`
added mssql_escalate_executeas_sqli.rb
Automatically clear previous log/metasploit/framework/spec/constants/each.log

MSP-11130

Have a task, 'metasploit:framework:spec:constants:each:clean' run before
`rake spec` that removes the previous
`log/metasploit/framework/spec/constants/each.log` so that the user doesn't
have to manually remove the load when removing
`Metasploit::Framework::Spec::Constants::Each.configure!` from
`spec/spec_helper.rb`.
Incorporate @jhart-r7's better fix
Revert "Add .log extension to metasploit/framework/spec/constants/suite log"

MSP-11130

This reverts commit 4f986c4a48d2cb06fd1d95cdd663f4581cd5082e.

Extension wasn't there because it was a directory name and a log file
name.
Updates to better OWA fix
Land #4109, tnftp savefile exploit from @wvu-r7