into 5.12 working on the update function