Fix inconsistent usage of DND event data

The cast check was using a different way to access the data than the
cast itself.

Change-Id: Ide9507924882d053cd0ef8a8254ddda22184c57b
Signed-off-by: Robin Stocker <robin@nibor.org>
Update interactive rebase plan row status icons

"Todo" icon is removed and "checkmark" icon is updated.

Change-Id: Ifea5d49ef8229cc18f1c0942076cd371e818313a
Signed-off-by: Vadim Dmitriev <dmgloss@mail.ru>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Disable interactive rebase view action toolbar if selection is empty

Now action toolbar in the "Interactive Rebase" view is disabled if
changeset selection is empty. Before the change toolbar remained active
which was misleading.

Bug: 441923
Change-Id: I6d4269b8ee72e69a44b1784c725ef9296cb1c5d4
Signed-off-by: Vadim Dmitriev <dmgloss@mail.ru>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Suppress "Unnecessary cast" errors in Eclipse Mars (4.5)

Bug 430981 changed the API of IServiceLocator#getService(Class) and
made casts unnecessary. But we still need to compile against older
releases. CommonUtils#getService(..) is a solution that works in both
worlds.

Bug: 441615
Change-Id: I4ce665fe3f66278f29d8d7e16f083be0e31a3ae8
Signed-off-by: Markus Keller <markus_keller@ch.ibm.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
[historyView] Use separate diff viewer instead of embedding into message

The diff viewer is the same as in the "Diff" tab of the commit viewer.
It still shares its scroll bar with the message.

The advantage is that when a file is selected, only the diff has to be
updated, not the whole message. We can also make the commit message
collapsible or extract other parts from the comment (such as the list of
branches/tags). Also, the hyperlink detectors now only run on the commit
message, not on the diff.

Bug: 440125
Change-Id: I6dc79f75eb0a63dde64cdf33d8e66fc594c327ab
Signed-off-by: Robin Stocker <robin@nibor.org>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Show a rebase result dialog if cherry-picking fails.

This will show a rebase result dialog if cherry-picking a commit fails.
This is the same dialog used for regular rebasing.

Bug: 443016
Change-Id: I0a88289f74913ccb47ace8ad9d59e9214ae2314a
Signed-off-by: Maik Schreiber <blizzy@blizzy.de>