update for framework logic