errggg
got it working for github, had to remove the user.provider and user.uid from the find_for_github method as these are done automatically by devise.  I also added a method to the controller to push provider and uid into the accepted params, but this shouldnt matter since it is happening on the devise registrations controller