working on string code
done string code