question working properly

can be done better if we have some time in the future