Ah yes. Any idea why pep8 doesn't catch these?


On Fri, Feb 7, 2014 at 1:34 PM, Jorge Cañardo Alastuey <
notifications@github.com> wrote:

> In bipy/core/workflow.py:
>
> > +            raise AttributeError("%s doesn't have DebugTrace!" % obj.__class__)
> > +
> > +        obj.DebugTrace.append(f.__name__)
> > +        return f(self, *args, **kwargs)
> > +
> > +    return update_wrapper(wrapped, f)
> > +
> > +
> > +def _tag_function(f):
> > +    """Tag, you're it"""
> > +    setattr(f, '__workflowtag__', None)
> > +
> > +
> > +class priority(object):
> > +    """Sets a function priority"""
> > +    def __init__(self, Priority):
>
> Good, I like how it makes more explicit how they're used.
>
> I still feel that other names need to be updated (there are methods and
> attributes like doShortCircuit, FinalState, Option... that should become
> something like do_short_circuit, final_state, option...). Am I
> overlooking something? Some methods like __call__ in Workflow already use
> pep8-approved names for parameters.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/biocore/bipy/pull/84/files#r9554139>
> .
>