Oops that slipped by


On Fri, Feb 7, 2014 at 4:05 PM, Gianni Chiappetta
<notifications@github.com>wrote:

> In src/secretary/core.cljs:
>
> > -(defn render-route [route m]
> > -  (.replace route (js/RegExp. ":[^/]+" "g") (fn [$1] (let [lookup (keyword (subs $1 1))]
> > -                                        (m lookup $1)))))
> > +(defn render-route
> > +  ([route params opts]
> > +     (render-route route (merge params opts)))
> > +  ([route {:keys [query-params] :as m}]
> > +     (let [path (.replace route (js/RegExp. ":[^/]+" "g")
> > +                          (fn [$1] (let [lookup (keyword (subs $1 1))]
> > +                                    (m lookup $1))))]
> > +       (if-let [query-string (and query-params
> > +                                  (encode-query-params query-params))]
> > +         (str path "?" query-string)
> > +         path))))
> > +
> > +
>
> Not critical, but watch out for that extra whitespace.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/gf3/secretary/pull/8/files#r9557155>
> .
>